Skip to content

Assert in OMASA bitrate switching -10 dB LTV input, bw_detect_fx

Basic info

Bug description

Assert happens in frame 4198 with the inputs described below. The line that triggers the assert is in the bw_detect_fx.c

https://forge.3gpp.org/rep/sa4/audio/ivas-basop/-/blob/main/lib_enc/bw_detect_fx.c#L127

L_tmp = L_add_sat( L_tmp, L_shl( L_deposit_l( cldfb_bin_Exp[0] ), 31 - LD_DATA_SCALE ) ); /* Q25 */

where cld_fb_bin_Exp[0] is -66 and this gives a left shift of a negative number. Who are the experts on this module? FhG? @fotopoulou, I'm assigning it to you, but feel free to reassign.

image.png

Ways to reproduce

Inputs available in LTV with -10 dB scaling.

cp -v /usr/local/ltv/* scripts/testv
python3 tests/scale_pcm.py scripts/testv 0.3162 

IVAS_cod -ism_masa 3 1 scripts/testv/ltv48_OMASA_1ISM_1TC_ISM1.csv scripts/testv/ltv48_OMASA_2ISM_1TC_ISM2.csv scripts/testv/ltv48_OMASA_3ISM_1TC_ISM3.csv scripts/testv/ltv48_OMASA_3ISM_1TC.met scripts/switchPaths/sw_13k2_512k_2fr_start_48k_omasatechs_3ism.bin 48 scripts/testv/ltv48_OMASA_3ISM_1TC.wav out.192