BASOP main does not build in MSVC Release

Main does not build in MSVC Release

Open

created by vaclav

The basop main does not compile in MSVC Release mode and returns following errors:

Severity

Code

Description

Project

File

Line
Error C1083 Cannot open include file: 'ivas_rtp_pi_data.h': No such file or directory lib_dec

..\ivas-basop\lib_dec\lib_dec.h

 40
Error (active) E0020 identifier "IVAS_PIDATA_ACOUSTIC_ENV" is undefined lib_dec

..\ivas-basop\lib_dec\lib_dec_fx.c

 3452
Error (active) E1696 cannot open source file "ivas_rtp_pi_data.h" lib_dec

..\ivas-basop\lib_dec\lib_dec.h

 40
Error (active) E1696 cannot open source file "ivas_rtp_pi_data.h" lib_dec

..\ivas-basop\lib_dec\lib_dec_fx.c

 45

This is due to the issue in included directories in the MSVC project file lib_dec.vcxproj. While there is in the Debug mode:

..\lib_basop;..\lib_com;..\lib_debug;..\lib_dec;..\lib_enc;..\lib_rend;..\lib_isar;..\lib_rend;..\lib_lc3plus;..\lib_util;.%(AdditionalIncludeDirectories)

and it compiles fine, the ..\lib_util include is missing in the Release mode:

..\lib_basop;..\lib_com;..\lib_debug;..\lib_dec;..\lib_enc;..\lib_rend;..\lib_isar;..\lib_rend;..\lib_lc3plus;.%(AdditionalIncludeDirectories)

A short-time solution would be to add the missing include into the Release mode.

However, ..\lib_util should be included only from an application or other utility files and not from the codec library as it is currently the case in lib_dec_fx.c:

#ifdef IVAS_RTPDUMP
#include "ivas_rtp_pi_data.h"
#endif

and lib_dec.h:

#ifdef IVAS_RTPDUMP_ACOUSTIC_ENVIRONMENT
#include "ivas_rtp_pi_data.h"
#endif

From the framework point of view, these includes are wrong, should be removed and the declarations in ivas_rtp_pi_data.h should be done somewhere else, e.g. in common_api_types.h.