Extra "return error" in IVAS_REND_Open

Basic info

  • Fixed point:
    • Renderer (fixed): 496d928d

Bug description

There is clear mistake at the end of IVAS_REND_Open. See below

    IF( EQ_32( hIvasRend->outputConfig, IVAS_AUDIO_CONFIG_BINAURAL_ROOM_REVERB ) )
    {
        if ( hIvasRend->hHrtfs.hHrtfStatistics == NULL )
        {
            /* Allocate and init HRTF statistics */
            IF( NE_32( ( error = ivas_reverb_HRTF_statistics_open_fx( &( hIvasRend->hHrtfs.hHrtfStatistics ), hIvasRend->sampleRateOut ) ), IVAS_ERR_OK ) )
            {
                return error;
            }
        }
        {
            return error;
        }
    }

    return IVAS_ERR_OK;

That unconditional return in general is not skipping any code but will return uninitialized error-value. Float does not have it.

Edited Apr 08, 2026 by Tapani Pihlajakuja
Assignee Loading
Time tracking Loading