Porting error in EFAP function add_vertex_to_convex_hull_fx

Basic info

  • Fixed point:
    • Encoder (fixed): 496d928d
    • Decoder (fixed): 496d928d

Bug description

There is a pretty evident porting mistake in EFAP function add_vertex_to_convex_hull_fx() as shown below

    centroid[0] = Mpy_32_32( centroid[0], tmp32 ); // q27
    move32();
    centroid[1] = Mpy_32_32( centroid[1], tmp32 ); // q27
    move32();
    centroid[2] = Mpy_32_32( centroid[1], tmp32 ); // q27 <- BUG HERE
    move32();

Not sure of the significance of the effect but probably can create some differences in creating the EFAP layout.

Assignee Loading
Time tracking Loading