Admin message

WARNING! Gitlab maintenance operation scheduled for Monday, 20 April between 12:00 and 14:00 (CET). During this time window, short service interruptions (less than 5 minutes) may occur. Thank you in advance for your understanding.

Possible porting error in TDREND_REND_RenderSourceHRFilt_fx

Basic info

  • Float reference:
    • Encoder (float):
    • Decoder (float):
  • Fixed point:
    • Encoder (fixed):
    • Decoder (fixed): 496d928d

Bug description

Looks like a clear porting error in TDREND_REND_RenderSourceHRFilt_fx, see below

    /* Scaling prev and delta HRF filter values to common Q-factor */
    Scale_sig32( Src_p->hrf_left_prev_fx, Src_p->filterlength, sub( Src_p->hrf_left_prev_e, left_filter_e ) );
    Scale_sig32( hrf_left_delta_fx, Src_p->filterlength, sub( *hrf_left_delta_e, left_filter_e ) );
    Scale_sig32( Src_p->hrf_right_prev_fx, Src_p->filterlength, sub( Src_p->hrf_right_prev_e, right_filter_e ) );
    Scale_sig32( hrf_right_delta_fx, Src_p->filterlength, sub( *hrf_right_delta_e, left_filter_e ) ); <-- BUG HERE

It does not look like it would make sense to scale here with left_filter_e but of course it could be intentional.

Assignee Loading
Time tracking Loading