Possible porting error in TDREND_REND_RenderSourceHRFilt_fx
Basic info
- Float reference:
- Encoder (float):
- Decoder (float):
- Fixed point:
- Encoder (fixed):
- Decoder (fixed): 496d928d
Bug description
Looks like a clear porting error in TDREND_REND_RenderSourceHRFilt_fx, see below
/* Scaling prev and delta HRF filter values to common Q-factor */
Scale_sig32( Src_p->hrf_left_prev_fx, Src_p->filterlength, sub( Src_p->hrf_left_prev_e, left_filter_e ) );
Scale_sig32( hrf_left_delta_fx, Src_p->filterlength, sub( *hrf_left_delta_e, left_filter_e ) );
Scale_sig32( Src_p->hrf_right_prev_fx, Src_p->filterlength, sub( Src_p->hrf_right_prev_e, right_filter_e ) );
Scale_sig32( hrf_right_delta_fx, Src_p->filterlength, sub( *hrf_right_delta_e, left_filter_e ) ); <-- BUG HERE
It does not look like it would make sense to scale here with left_filter_e but of course it could be intentional.