Function ivas_encode_masaism_metadata_fx has wrong accumulation and suboptimal porting

Basic info

  • Float reference:
    • Encoder (float): 69d52e95006f4fd8f4a75874acaeee89928f8531
    • Decoder (float):
  • Fixed point:
    • Encoder (fixed): 26ae1a66
    • Decoder (fixed):

Bug description

Inspecting the OMASA-related encoding function ivas_encode_masaism_metadata_fx, there is at least one copy-paste error causing one path to produce wrong ratios. Also overall, the usage of temporary variables is not always logical.