Some important warnings that need attentions
Here is some of the warnings under msvc. Some of them can have an important impact.
- Function concealment_update2_x receives a Word32* while it should be Word16*
- In TonalMDCTconcealment -> powerSpectrum and invScaleFactors are floating point values used to compute norm (Ex: q_ps = s_min( q_ps, norm_l( powerSpectrum[k] ) );)
- Similarly in TonalComponentDetection
- in ivas_stereo_switching_dec.c: Huge number of incompatible type warnings, most of them are Word vectors that are passed to function instead of float vector or vice-versa
- in ivas_stereo_mdct_core_dec_fx: Word32 stored into a Word16 without any checks, there the values seem OK, but still it should be addressed
- in ivas_stereo_dft_dec.c : Word16 vector passed to a function that is expecting a Word32 vector
- i nivas_sce_dec_fx.c : Word32 vector passes to a function that is expecting a float vector
- EPSILON_FX has different value (0 in cnst.h and 1 in IVAS_out_setup_conversion)
- in ivas_jbm_dec: many warnings of a variable that hides previous local declaration
- in ivas_ism_dtx_dec.c : Word32 value passes into a function that is expecting Word16
- in ivas_corecoder_dec_reconf : Word32 passes as a Word16 without any check ( L_mult0( L_mult0(... )
- in igf_scf_enc_fx : const Word16 * expected but table is const uint16_t *
- in swb_bwe_com_fx : Word32 used as Word16 without checks
Edited by vaillancour