[complexity] missing pop_wmops() in vbap_init_data()
Basic info
- Present with df307502 (tested on macOS)
Bug description
Missing pop_wmops()
can cause unbalanced push/pop calls leading to the following error:
update_wmops(): WMOPS caller stack corrupted - check that all push_wmops() are matched with pop_wmops()!
The cause seems to be a missing pop_wmops()
in vbap_init_data()
:
https://forge.3gpp.org/rep/sa4/audio/ivas-basop/-/blob/main/lib_rend/ivas_vbap.c#L470
This is present in the inactive float code lower down: https://forge.3gpp.org/rep/sa4/audio/ivas-basop/-/blob/main/lib_rend/ivas_vbap.c#L719
Ways to reproduce
Decode this bitstream with an instrumented FX decoder: ltv48_MC51_MC_5_1_ball_wb_rs_fer_ep_10pct_fer_g192.192.zip
./IVAS_cod -mc 5_1 -max_band wb scripts/switchPaths/sw_13k2_512k.bin 16 ltv48_MC51_16_5_1.pcm bit
eid-xor -vbr -fer bit ep_10pct_fer.g192 bit_err
./IVAS_dec 7_1_4 16 bit_err out
Edited by Archit Tamarapu