Skip to content

Wrong value of energy ratio in MASA EXT mode

Basic info

  • Encoder (float):
  • Decoder:

Bug description

When the energy ratio value is prepared to be written in the MASA metadata file in EXT mode, it is transformed into Word8. If it has exactly the value 1 in Q30, after:

UWord8 tmp = (UWord8) L_shr( hQMetaData->q_direction[dir].band_data[b_old].energy_ratio_fx[sf], Q30 - 8 ); // Q8 extOutMeta->diffuseToTotalRatio[sf][b_new] = (UWord8) sub( extOutMeta->diffuseToTotalRatio[sf][b_new], tmp ); // Q8

it becomes 0 instead of 1.

Ways to reproduce

Decoding in EXT mode of MASA, potentially all bitrates. At lower bitrates there is lower probability to be triggered due to the energy ratio values.

(Clear steps or refer to a failing automated test, e.g. with a pipeline link)