From 9f4660512e591ac6eb5d0c6395d8817729fe6447 Mon Sep 17 00:00:00 2001
From: Devansh Kandpal <43807487+mrkandpal@users.noreply.github.com>
Date: Wed, 6 Aug 2025 09:07:24 +0200
Subject: [PATCH 1/3] compiler switch + changes for mr 1678

---
 lib_com/options.h      |  2 ++
 lib_rend/lib_rend_fx.c | 12 ++++++++++++
 2 files changed, 14 insertions(+)

diff --git a/lib_com/options.h b/lib_com/options.h
index 53f46102a..c252e523e 100755
--- a/lib_com/options.h
+++ b/lib_com/options.h
@@ -114,6 +114,8 @@
 
 #define FIX_1068_ASAN_IN_MC_2_BINAURAL_ROOM_IR          /* issue 1068 : Memory leak in MC to BINAURAL_ROOM decoding with bitrate switching*/
 
+#define FIX_1129_EXT_REND_OUTPUT_HIGH                   /* Philips: issue 1129: External renderer BINAURAL_ROOM_REVERB format output level too high compared to internal rendering output */
+
 /* #################### End BASOP porting switches ############################ */
 
 #endif
diff --git a/lib_rend/lib_rend_fx.c b/lib_rend/lib_rend_fx.c
index ae4b2ef02..e4123499d 100644
--- a/lib_rend/lib_rend_fx.c
+++ b/lib_rend/lib_rend_fx.c
@@ -2964,6 +2964,9 @@ static ivas_error updateSbaPanGains(
                     break;
                 }
                 case IVAS_AUDIO_CONFIG_BINAURAL:
+#ifdef FIX_1129_EXT_REND_OUTPUT_HIGH
+                case IVAS_AUDIO_CONFIG_BINAURAL_ROOM_REVERB:
+#endif
                 {
                     if ( hRendCfg->split_rend_config.rendererSelection == ISAR_SPLIT_REND_RENDERER_SELECTION_FASTCONV )
                     {
@@ -2983,7 +2986,9 @@ static ivas_error updateSbaPanGains(
                 }
                     BREAK;
                 case IVAS_AUDIO_CONFIG_BINAURAL_ROOM_IR:
+#ifndef FIX_1129_EXT_REND_OUTPUT_HIGH
                 case IVAS_AUDIO_CONFIG_BINAURAL_ROOM_REVERB:
+#endif
                     IF( NE_32( ( error = initSbaPanGainsForMcOut( inputSba, IVAS_AUDIO_CONFIG_7_1_4, NULL ) ), IVAS_ERR_OK ) )
                     {
                         return error;
@@ -7843,11 +7848,18 @@ static ivas_error renderInputSba(
                 case IVAS_AUDIO_CONFIG_BINAURAL_SPLIT_PCM:
                     error = renderSbaToSplitBinaural( sbaInput, outConfig, outAudio );
                     break;
+#ifdef FIX_1129_EXT_REND_OUTPUT_HIGH
+                case IVAS_AUDIO_CONFIG_BINAURAL:
+                case IVAS_AUDIO_CONFIG_BINAURAL_ROOM_REVERB:
+                    error = renderSbaToBinaural( sbaInput, outConfig, outAudio );
+                    break;
+#else
                 case IVAS_AUDIO_CONFIG_BINAURAL:
                     error = renderSbaToBinaural( sbaInput, outConfig, outAudio );
                     BREAK;
                 case IVAS_AUDIO_CONFIG_BINAURAL_ROOM_IR:
                 case IVAS_AUDIO_CONFIG_BINAURAL_ROOM_REVERB:
+#endif
                     error = renderSbaToBinauralRoom( sbaInput, outConfig, outAudio );
                     BREAK;
                 default:
-- 
GitLab


From c37256c2e11084befbfb91c5d4f04f865dfdfd56 Mon Sep 17 00:00:00 2001
From: Devansh Kandpal <43807487+mrkandpal@users.noreply.github.com>
Date: Wed, 6 Aug 2025 09:29:15 +0200
Subject: [PATCH 2/3] MR marked ready, restart pipeline

-- 
GitLab


From 55714b3b01b0b7da9d1a72f1bb93cea09786344b Mon Sep 17 00:00:00 2001
From: Devansh Kandpal <43807487+mrkandpal@users.noreply.github.com>
Date: Thu, 21 Aug 2025 10:14:52 +0200
Subject: [PATCH 3/3] Missing switch case added...

---
 lib_rend/lib_rend_fx.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib_rend/lib_rend_fx.c b/lib_rend/lib_rend_fx.c
index 2c4baf4d0..0c44a6a62 100644
--- a/lib_rend/lib_rend_fx.c
+++ b/lib_rend/lib_rend_fx.c
@@ -8073,6 +8073,7 @@ static ivas_error renderInputSba(
                 case IVAS_AUDIO_CONFIG_BINAURAL_ROOM_REVERB:
                     error = renderSbaToBinaural( sbaInput, outConfig, outAudio );
                     break;
+                case IVAS_AUDIO_CONFIG_BINAURAL_ROOM_IR:
 #else
                 case IVAS_AUDIO_CONFIG_BINAURAL:
                     error = renderSbaToBinaural( sbaInput, outConfig, outAudio );
-- 
GitLab