From a0077fc7654f45b7dee4379993d8689d48e8b2d2 Mon Sep 17 00:00:00 2001 From: Marek Szczerba Date: Mon, 11 Aug 2025 16:56:52 +0200 Subject: [PATCH 1/3] Fix for handling output Q factor --- lib_rend/ivas_crend_fx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib_rend/ivas_crend_fx.c b/lib_rend/ivas_crend_fx.c index a8195dae3..9f0c177cb 100644 --- a/lib_rend/ivas_crend_fx.c +++ b/lib_rend/ivas_crend_fx.c @@ -2287,13 +2287,11 @@ ivas_error ivas_rend_crendProcessSubframe( IF( pCrend->hCrend[0]->hReverb != NULL ) { - *pCrend->p_io_qfactor = sub( *pCrend->p_io_qfactor, 2 ); - move16(); FOR( Word16 i = nchan_out; i < nchan_in; i++ ) { FOR( Word16 j = 0; j < n_samples_to_render; j++ ) { - output[i][j] = L_shr( output[i][j], 2 ); // Q = *pCrend->p_io_qfactor + output[i][j] = L_shr( output[i][j], *pCrend->p_io_qfactor ); move32(); } } -- GitLab From dccd7701d1ef2bbac8cebf1179e6affd454859d3 Mon Sep 17 00:00:00 2001 From: Marek Szczerba Date: Tue, 12 Aug 2025 11:06:47 +0200 Subject: [PATCH 2/3] Right shift by two as compared to Q factor reapplied --- lib_rend/ivas_crend_fx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib_rend/ivas_crend_fx.c b/lib_rend/ivas_crend_fx.c index 9f0c177cb..12b058cd7 100644 --- a/lib_rend/ivas_crend_fx.c +++ b/lib_rend/ivas_crend_fx.c @@ -2291,7 +2291,7 @@ ivas_error ivas_rend_crendProcessSubframe( { FOR( Word16 j = 0; j < n_samples_to_render; j++ ) { - output[i][j] = L_shr( output[i][j], *pCrend->p_io_qfactor ); + output[i][j] = L_shr( output[i][j], add( *pCrend->p_io_qfactor, 2 ) ); move32(); } } -- GitLab From 9a8ca69c5db99eb3557092cdda369d073e0be20b Mon Sep 17 00:00:00 2001 From: Marek Szczerba Date: Tue, 12 Aug 2025 13:19:56 +0200 Subject: [PATCH 3/3] Removed Q factor related reverb output scaling --- lib_rend/ivas_crend_fx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib_rend/ivas_crend_fx.c b/lib_rend/ivas_crend_fx.c index 12b058cd7..663e6d038 100644 --- a/lib_rend/ivas_crend_fx.c +++ b/lib_rend/ivas_crend_fx.c @@ -2291,7 +2291,7 @@ ivas_error ivas_rend_crendProcessSubframe( { FOR( Word16 j = 0; j < n_samples_to_render; j++ ) { - output[i][j] = L_shr( output[i][j], add( *pCrend->p_io_qfactor, 2 ) ); + output[i][j] = L_shr( output[i][j], 2 ); move32(); } } -- GitLab