From 25158942cd5666196c78da3f64750abb1c6ca6b4 Mon Sep 17 00:00:00 2001 From: rtyag Date: Mon, 18 Aug 2025 14:49:08 +1000 Subject: [PATCH 1/2] fix for issue 1907 --- lib_com/cnst.h | 2 +- lib_rend/ivas_rotation_fx.c | 4 ++-- lib_rend/lib_rend_fx.c | 8 +------- 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/lib_com/cnst.h b/lib_com/cnst.h index 59e9e89f1..377cad819 100644 --- a/lib_com/cnst.h +++ b/lib_com/cnst.h @@ -49,7 +49,7 @@ #define NUM_SAMPLES_320 (320) #define NUM_SAMPLES_160 (160) #define L_SUBFRAME_48k (240) -#define L_SUBFRAME_32k (180) +#define L_SUBFRAME_32k (160) #define L_SUBFRAME_16k (80) #define L_SUBFRAME_8k (40) #define Q31_BY_NUM_SAMPLES_960 ( 2239294 ) /* 1/959 in Q31 */ diff --git a/lib_rend/ivas_rotation_fx.c b/lib_rend/ivas_rotation_fx.c index 21b443a04..de6e10e0d 100644 --- a/lib_rend/ivas_rotation_fx.c +++ b/lib_rend/ivas_rotation_fx.c @@ -700,7 +700,7 @@ void rotateFrame_shd( move32(); BREAK; case L_SUBFRAME_32k: - tmp = Q31_BY_SUB_FRAME_180; + tmp = Q31_BY_NUM_SAMPLES_160; move32(); BREAK; case L_SUBFRAME_16k: @@ -837,7 +837,7 @@ void rotateFrame_sd( move32(); BREAK; case L_SUBFRAME_32k: - tmp = Q31_BY_SUB_FRAME_180; + tmp = Q31_BY_NUM_SAMPLES_160; move32(); BREAK; case L_SUBFRAME_16k: diff --git a/lib_rend/lib_rend_fx.c b/lib_rend/lib_rend_fx.c index 389b6a5a7..75a6de0d6 100644 --- a/lib_rend/lib_rend_fx.c +++ b/lib_rend/lib_rend_fx.c @@ -5437,7 +5437,7 @@ static void renderBufferChannelLerp_fx( move32(); move32(); BREAK; - case NUM_SAMPLES_160: + case L_SUBFRAME_32k: tmp = Q31_BY_NUM_SAMPLES_160; tmp1 = 159; /* NUM_SAMPLES_160 - 1 */ move32(); @@ -5449,12 +5449,6 @@ static void renderBufferChannelLerp_fx( move32(); move32(); BREAK; - case L_SUBFRAME_32k: - tmp = Q31_BY_SUB_FRAME_180; - tmp1 = 179; /* L_SUBFRAME_32k - 1 */ - move32(); - move32(); - BREAK; case L_SUBFRAME_16k: tmp = Q31_BY_SUB_FRAME_80; tmp1 = 79; /* L_SUBFRAME_16k - 1 */ -- GitLab From fa82cb9b93b2232e91a5a2006126d14d068d219b Mon Sep 17 00:00:00 2001 From: rtyag Date: Wed, 20 Aug 2025 12:21:31 +1000 Subject: [PATCH 2/2] removing comments that are not true anymore --- lib_dec/ivas_lfe_dec_fx.c | 1 - lib_rend/ivas_rotation_fx.c | 1 - 2 files changed, 2 deletions(-) diff --git a/lib_dec/ivas_lfe_dec_fx.c b/lib_dec/ivas_lfe_dec_fx.c index fb0141b72..d4d1d727e 100644 --- a/lib_dec/ivas_lfe_dec_fx.c +++ b/lib_dec/ivas_lfe_dec_fx.c @@ -409,7 +409,6 @@ void ivas_lfe_dec_fx( IF( hLFE->filter_state.order > 0 ) { - /* NOTE: this block is not getting hit by any stream present in pytest test suite */ /* Low Pass Filter */ ivas_filter_process_fx( &hLFE->filter_state, output_lfe_ch, output_frame, q_out ); } diff --git a/lib_rend/ivas_rotation_fx.c b/lib_rend/ivas_rotation_fx.c index de6e10e0d..d8e18f8a6 100644 --- a/lib_rend/ivas_rotation_fx.c +++ b/lib_rend/ivas_rotation_fx.c @@ -678,7 +678,6 @@ void rotateFrame_shd( const Word16 subframe_idx /* i : subframe index Q0 */ ) { - // Not yet tested, no test cases entering the function. Word16 i, l, n, m, offset; Word16 m1, m2; Word16 shd_rot_max_order; -- GitLab