From 55e99d2786cc81f5ccc4bfb158f32fa7e85b60df Mon Sep 17 00:00:00 2001 From: Jan Kiene Date: Wed, 3 Sep 2025 10:38:31 +0200 Subject: [PATCH 1/9] add DISABLE_HRTF variable --- .gitlab-ci/variables.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitlab-ci/variables.yml b/.gitlab-ci/variables.yml index 31d69a643..4879f331e 100644 --- a/.gitlab-ci/variables.yml +++ b/.gitlab-ci/variables.yml @@ -81,6 +81,8 @@ variables: RUNNER_TAG: "ivas-basop-linux" LOGS_BACKUP_SOURCE_DIR: "" LOGS_BACKUP_TARGET_DIR: "" + # set this to true to skip the external HRTF testcases in pytest calls + DISABLE_HRTF: "false" MANUAL_PIPELINE_TYPE: description: "Type for the manual pipeline run. Use 'pytest-compare' to run comparison test against reference float codec." value: 'default' -- GitLab From e122f006d30e6bd211daa23e8f26b97f09131188 Mon Sep 17 00:00:00 2001 From: Jan Kiene Date: Wed, 3 Sep 2025 10:39:13 +0200 Subject: [PATCH 2/9] [revert-me] disable HRTF model from file tests --- .gitlab-ci/variables.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci/variables.yml b/.gitlab-ci/variables.yml index 4879f331e..e86fa27c2 100644 --- a/.gitlab-ci/variables.yml +++ b/.gitlab-ci/variables.yml @@ -82,7 +82,7 @@ variables: LOGS_BACKUP_SOURCE_DIR: "" LOGS_BACKUP_TARGET_DIR: "" # set this to true to skip the external HRTF testcases in pytest calls - DISABLE_HRTF: "false" + DISABLE_HRTF: "true" MANUAL_PIPELINE_TYPE: description: "Type for the manual pipeline run. Use 'pytest-compare' to run comparison test against reference float codec." value: 'default' -- GitLab From 748ac23dad67474264854a2bcf6902c6f7219370 Mon Sep 17 00:00:00 2001 From: Jan Kiene Date: Wed, 3 Sep 2025 10:40:01 +0200 Subject: [PATCH 3/9] [revert-me] change CI ref for testing --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 93d77386f..2486e5a86 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1,7 +1,7 @@ variables: # note: GitLab cannot reference variables defined by users in the include ref:, we need to use a YAML anchor for this # see https://docs.gitlab.com/ci/yaml/includes/#use-variables-with-include for more information - IVAS_CODEC_CI_REF: &IVAS_CODEC_CI_REF main + IVAS_CODEC_CI_REF: &IVAS_CODEC_CI_REF kiene/disable-hrtf-testcases-mechanism include: - project: ivas-codec-pc/ivas-codec-ci -- GitLab From 400a0e2675dc73a2c98df05c73a62f8cb2dfbdf3 Mon Sep 17 00:00:00 2001 From: Jan Kiene Date: Wed, 3 Sep 2025 11:01:27 +0200 Subject: [PATCH 4/9] dummy commit to trigger CI -- GitLab From 290bfb6237a6b5f859c1c572c873577215686c75 Mon Sep 17 00:00:00 2001 From: Jan Kiene Date: Wed, 3 Sep 2025 11:44:44 +0200 Subject: [PATCH 5/9] dummy commit to trigger CI -- GitLab From e888e337eb5fbe0409c4e1f5011e929944c393b3 Mon Sep 17 00:00:00 2001 From: Jan Kiene Date: Wed, 3 Sep 2025 12:51:28 +0200 Subject: [PATCH 6/9] Revert "[revert-me] change CI ref for testing" This reverts commit 748ac23dad67474264854a2bcf6902c6f7219370. --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 2486e5a86..93d77386f 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -1,7 +1,7 @@ variables: # note: GitLab cannot reference variables defined by users in the include ref:, we need to use a YAML anchor for this # see https://docs.gitlab.com/ci/yaml/includes/#use-variables-with-include for more information - IVAS_CODEC_CI_REF: &IVAS_CODEC_CI_REF kiene/disable-hrtf-testcases-mechanism + IVAS_CODEC_CI_REF: &IVAS_CODEC_CI_REF main include: - project: ivas-codec-pc/ivas-codec-ci -- GitLab From 32623956cd096c18e6096156335ccc7a48d239c1 Mon Sep 17 00:00:00 2001 From: Jan Kiene Date: Wed, 3 Sep 2025 12:51:37 +0200 Subject: [PATCH 7/9] Revert "[revert-me] disable HRTF model from file tests" This reverts commit e122f006d30e6bd211daa23e8f26b97f09131188. --- .gitlab-ci/variables.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci/variables.yml b/.gitlab-ci/variables.yml index e86fa27c2..4879f331e 100644 --- a/.gitlab-ci/variables.yml +++ b/.gitlab-ci/variables.yml @@ -82,7 +82,7 @@ variables: LOGS_BACKUP_SOURCE_DIR: "" LOGS_BACKUP_TARGET_DIR: "" # set this to true to skip the external HRTF testcases in pytest calls - DISABLE_HRTF: "true" + DISABLE_HRTF: "false" MANUAL_PIPELINE_TYPE: description: "Type for the manual pipeline run. Use 'pytest-compare' to run comparison test against reference float codec." value: 'default' -- GitLab From 0cf11ee3c67edc7c1cf2e855352d2b4bf14e1fbe Mon Sep 17 00:00:00 2001 From: Jan Kiene Date: Wed, 3 Sep 2025 14:32:42 +0200 Subject: [PATCH 8/9] move default value for DISABLE_HRTF from here to CI repo --- .gitlab-ci/variables.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.gitlab-ci/variables.yml b/.gitlab-ci/variables.yml index 4879f331e..31d69a643 100644 --- a/.gitlab-ci/variables.yml +++ b/.gitlab-ci/variables.yml @@ -81,8 +81,6 @@ variables: RUNNER_TAG: "ivas-basop-linux" LOGS_BACKUP_SOURCE_DIR: "" LOGS_BACKUP_TARGET_DIR: "" - # set this to true to skip the external HRTF testcases in pytest calls - DISABLE_HRTF: "false" MANUAL_PIPELINE_TYPE: description: "Type for the manual pipeline run. Use 'pytest-compare' to run comparison test against reference float codec." value: 'default' -- GitLab From 9b1964262faafb28bf1ad3c5dadb3c180c9bb7c8 Mon Sep 17 00:00:00 2001 From: Jan Kiene Date: Wed, 3 Sep 2025 14:34:17 +0200 Subject: [PATCH 9/9] add DISABLE_HRTF variable setting back for easier usage --- .gitlab-ci/variables.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitlab-ci/variables.yml b/.gitlab-ci/variables.yml index 31d69a643..4879f331e 100644 --- a/.gitlab-ci/variables.yml +++ b/.gitlab-ci/variables.yml @@ -81,6 +81,8 @@ variables: RUNNER_TAG: "ivas-basop-linux" LOGS_BACKUP_SOURCE_DIR: "" LOGS_BACKUP_TARGET_DIR: "" + # set this to true to skip the external HRTF testcases in pytest calls + DISABLE_HRTF: "false" MANUAL_PIPELINE_TYPE: description: "Type for the manual pipeline run. Use 'pytest-compare' to run comparison test against reference float codec." value: 'default' -- GitLab