From 213449994c0ed5baee5a2fb81981f5ef53c76213 Mon Sep 17 00:00:00 2001 From: Tapani Pihlajakuja Date: Wed, 22 Oct 2025 10:35:51 +0300 Subject: [PATCH 1/3] Add missing part from IVAS_DEC_GetEditableParameters and adjust to be in line with float version. --- lib_dec/lib_dec_fx.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/lib_dec/lib_dec_fx.c b/lib_dec/lib_dec_fx.c index 9f6b28ed3..e1a31d4cf 100644 --- a/lib_dec/lib_dec_fx.c +++ b/lib_dec/lib_dec_fx.c @@ -4217,14 +4217,23 @@ ivas_error IVAS_DEC_GetEditableParameters( hIvasEditableParameters->num_obj = 0; move16(); } +#ifdef DEBUGGING ELSE { assert( 0 && "This should never happen!" ); } +#endif } +#ifdef NONBE_1217_INIT_OBJ_EDIT + ELSE IF( EQ_32( st_ivas->ivas_format, MASA_ISM_FORMAT ) || ( EQ_32( st_ivas->ivas_format, MASA_FORMAT ) && GT_16( st_ivas->nchan_ism, 0 ) ) ) +#else ELSE IF( EQ_32( st_ivas->ivas_format, MASA_ISM_FORMAT ) && ( EQ_32( ism_mode, ISM_MASA_MODE_PARAM_ONE_OBJ ) || EQ_32( ism_mode, ISM_MASA_MODE_DISC ) ) ) +#endif { /* object editing possible only in two highest OMASA modes */ +#ifdef NONBE_1217_INIT_OBJ_EDIT + test(); +#endif IF( EQ_32( ism_mode, ISM_MASA_MODE_DISC ) ) { FOR( obj = 0; obj < hIvasEditableParameters->num_obj; obj++ ) @@ -4249,7 +4258,11 @@ ivas_error IVAS_DEC_GetEditableParameters( move16(); } } +#ifdef NONBE_1217_INIT_OBJ_EDIT + ELSE IF ( EQ_32( ism_mode, ISM_MASA_MODE_PARAM_ONE_OBJ ) ) +#else ELSE +#endif { /* Handle MONO output */ IF( NE_32( st_ivas->renderer_type, RENDERER_MONO_DOWNMIX ) ) @@ -4285,6 +4298,18 @@ ivas_error IVAS_DEC_GetEditableParameters( move16(); } } +#ifdef NONBE_1217_INIT_OBJ_EDIT + ELSE IF ( EQ_32( ism_mode, ISM_MASA_MODE_MASA_ONE_OBJ ) || EQ_32( ism_mode, ISM_MODE_NONE ) ) + { + hIvasEditableParameters->num_obj = 0; + } +#ifdef DEBUGGING + ELSE + { + assert( 0 && "This should never happen!" ); + } +#endif +#endif } return IVAS_ERR_OK; @@ -4440,10 +4465,12 @@ ivas_error IVAS_DEC_SetEditableParameters( return IVAS_ERR_OBJECTS_EDITING_NOT_SUPPORTED; } } +#ifdef DEBUGGING ELSE { assert( 0 && "This should never happen!" ); } +#endif } ELSE IF( EQ_16( st_ivas->ivas_format, MASA_ISM_FORMAT ) && ( EQ_16( ism_mode, ISM_MASA_MODE_PARAM_ONE_OBJ ) || EQ_16( ism_mode, ISM_MASA_MODE_DISC ) ) ) { -- GitLab From 34561eaf948c19b51657c66c2525b2761d0b276e Mon Sep 17 00:00:00 2001 From: Tapani Pihlajakuja Date: Wed, 22 Oct 2025 10:40:29 +0300 Subject: [PATCH 2/3] Clang format --- lib_dec/lib_dec_fx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib_dec/lib_dec_fx.c b/lib_dec/lib_dec_fx.c index e1a31d4cf..cbb26a46b 100644 --- a/lib_dec/lib_dec_fx.c +++ b/lib_dec/lib_dec_fx.c @@ -4259,7 +4259,7 @@ ivas_error IVAS_DEC_GetEditableParameters( } } #ifdef NONBE_1217_INIT_OBJ_EDIT - ELSE IF ( EQ_32( ism_mode, ISM_MASA_MODE_PARAM_ONE_OBJ ) ) + ELSE IF( EQ_32( ism_mode, ISM_MASA_MODE_PARAM_ONE_OBJ ) ) #else ELSE #endif @@ -4299,7 +4299,7 @@ ivas_error IVAS_DEC_GetEditableParameters( } } #ifdef NONBE_1217_INIT_OBJ_EDIT - ELSE IF ( EQ_32( ism_mode, ISM_MASA_MODE_MASA_ONE_OBJ ) || EQ_32( ism_mode, ISM_MODE_NONE ) ) + ELSE IF( EQ_32( ism_mode, ISM_MASA_MODE_MASA_ONE_OBJ ) || EQ_32( ism_mode, ISM_MODE_NONE ) ) { hIvasEditableParameters->num_obj = 0; } -- GitLab From bab0c0734b35039b9e877235e7830083c1ec02f6 Mon Sep 17 00:00:00 2001 From: Tapani Pihlajakuja Date: Wed, 22 Oct 2025 10:51:02 +0300 Subject: [PATCH 3/3] Test with OE tests pipeline --- .gitlab-ci/variables.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab-ci/variables.yml b/.gitlab-ci/variables.yml index 817be6f79..6994033e1 100644 --- a/.gitlab-ci/variables.yml +++ b/.gitlab-ci/variables.yml @@ -1,4 +1,5 @@ variables: + BASOP_CI_BRANCH_PC_REPO: "ci/port_288_enable_object_editing_tests" TESTV_DIR: "/usr/local/testv" LTV_DIR: "/usr/local/ltv" EVS_BE_TEST_DIR_BASOP: "/usr/local/be_2_evs_basop" -- GitLab