From 368bc9b742ed9499a1a9f12bc493f5db506189c3 Mon Sep 17 00:00:00 2001 From: Tapani Pihlajakuja Date: Fri, 23 Jan 2026 20:11:24 +0200 Subject: [PATCH 1/2] Fix basop issue 2354 by initializing diffusenesss Q-value to Q30. --- lib_com/options.h | 1 + lib_rend/ivas_dirac_rend_fx.c | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/lib_com/options.h b/lib_com/options.h index c7cd38dd8..7b216f4eb 100644 --- a/lib_com/options.h +++ b/lib_com/options.h @@ -107,6 +107,7 @@ #define FIX_2330_CLANG_18_WARNINGS_REND /* FhG: Fix renderer warnings */ #define FIX_BASOP_2350_HARM_0B_BWE /* VA: basop issue 2350: harmonization of the 0b BWE */ #define FIX_2349_HARM_FIND_UV /* VA: basop issue 2349: harmonization of find_uv() function */ +#define FIX_BASOP_2354_MSAN_DIFF_Q_VALUE /* Nokia: Initialize Q value of diffuseness in rendering to Q30 */ /* #################### End BE switches ################################## */ diff --git a/lib_rend/ivas_dirac_rend_fx.c b/lib_rend/ivas_dirac_rend_fx.c index 7eb2f83d6..024fa63a1 100644 --- a/lib_rend/ivas_dirac_rend_fx.c +++ b/lib_rend/ivas_dirac_rend_fx.c @@ -253,6 +253,10 @@ ivas_error ivas_spat_hSpatParamRendCom_config_fx( move16(); hSpatParamRendCom->numIsmDirections = 0; move16(); +#ifdef FIX_2354_MSAN_DIFF_Q_VALUE + hSpatParamRendCom->q_diffuseness_vector = Q30; + move16(); +#endif } /*-----------------------------------------------------------------* -- GitLab From 44a87dd7cce4c8ad5af2149d90f922c5d469ad1c Mon Sep 17 00:00:00 2001 From: Dominik Weckbecker Date: Tue, 27 Jan 2026 10:17:13 +0100 Subject: [PATCH 2/2] fix ifdef in ivas_dirac_rend_fx.c --- lib_rend/ivas_dirac_rend_fx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib_rend/ivas_dirac_rend_fx.c b/lib_rend/ivas_dirac_rend_fx.c index 024fa63a1..e7df45b6c 100644 --- a/lib_rend/ivas_dirac_rend_fx.c +++ b/lib_rend/ivas_dirac_rend_fx.c @@ -253,7 +253,7 @@ ivas_error ivas_spat_hSpatParamRendCom_config_fx( move16(); hSpatParamRendCom->numIsmDirections = 0; move16(); -#ifdef FIX_2354_MSAN_DIFF_Q_VALUE +#ifdef FIX_BASOP_2354_MSAN_DIFF_Q_VALUE hSpatParamRendCom->q_diffuseness_vector = Q30; move16(); #endif -- GitLab