From 20caaf8d402aa11e312058d8323dfbb2f60283ce Mon Sep 17 00:00:00 2001 From: Markus Multrus Date: Wed, 28 Jan 2026 21:07:25 +0100 Subject: [PATCH] Initialize Q_A_itf, to avoid reading of uninitialized memory in case ITF is not triggered --- lib_com/options.h | 1 + lib_dec/dec_tcx_fx.c | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/lib_com/options.h b/lib_com/options.h index e11d5dffa..6f12164eb 100644 --- a/lib_com/options.h +++ b/lib_com/options.h @@ -102,6 +102,7 @@ #define FIX_2319_CLDFB_INIT_FLAGS /* FhG: basop issue 2319: init hs->flags during openCldfb(), to avoid reading of uninitialized memory */ #define FIX_BASOP_2357_OBJECT_EDIT_MSAN /* Nokia: basop issue 2357: initialize missing exponents in object edit */ #define FIX_BASOP_2354_MSAN_DIFF_Q_VALUE /* Nokia: Initialize Q value of diffuseness in rendering to Q30 */ +#define FIX_2383_INIT_Q_A_ITF /* FhG: Initialize Q_A_itf, to avoid reading of uninitialized memory in case ITF is not triggered */ /* #################### End BE switches ################################## */ diff --git a/lib_dec/dec_tcx_fx.c b/lib_dec/dec_tcx_fx.c index e48affb21..ed170d598 100644 --- a/lib_dec/dec_tcx_fx.c +++ b/lib_dec/dec_tcx_fx.c @@ -1075,6 +1075,10 @@ void decoder_tcx_fx( Word16 predictionGain; /* not counted */ predictionGain = 0; move16(); +#ifdef FIX_2383_INIT_Q_A_ITF + Q_A_itf = 15; + move16(); +#endif FOR( j = startLine; j < endLine; j++ ) { -- GitLab