From 0a34775b54272dabc253603d845dfb052aa52745 Mon Sep 17 00:00:00 2001 From: naghibza Date: Tue, 31 Mar 2026 17:11:01 +0200 Subject: [PATCH 1/2] Correct exponent scaling of outAudio.data_fx before buffer accumulation in renderSbaToBinaural() --- lib_com/options.h | 1 + lib_rend/lib_rend_fx.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/lib_com/options.h b/lib_com/options.h index c288b354c..c84288923 100644 --- a/lib_com/options.h +++ b/lib_com/options.h @@ -101,6 +101,7 @@ #define FIX_2488_PREVENT_NEG_PITCH /* VA: Fix for 2488, use saturation to prevent possible wrap-around, thus negative pitch values */ #define FIX_1547_ISMDTX_HANDLE /* VA: float issue 1547: fix use of 'hISMDTX' handle */ #define FIX_1540_EXPOSE_PT_IN_RTP_HEADER_API /* Expose Payload Type setting in RTP Header */ +#define FIX_2495_Q_ALIGN_OSBA_RENDERER /* FhG: Basop issue #2495: Corrected exponent scaling of outAudio.data_fx before buffer accumulation in renderSbaToBinaural(). */ /* ##################### End NON-BE switches ########################### */ diff --git a/lib_rend/lib_rend_fx.c b/lib_rend/lib_rend_fx.c index 8ade538fc..3c2b545f9 100644 --- a/lib_rend/lib_rend_fx.c +++ b/lib_rend/lib_rend_fx.c @@ -8672,6 +8672,9 @@ static ivas_error renderSbaToBinaural( IF( hCrend->hReverb != NULL ) { +#ifdef FIX_2495_Q_ALIGN_OSBA_RENDERER + scale_sig32( outAudio.data_fx, i_mult( outAudio.config.numChannels, outAudio.config.numSamplesPerChannel ), -Q2 ); // Align Q of outAudio.data_fx with Q of output_buffer_fx: *pCrend->p_io_qfactor = *outAudio.pq_fact - Q2 +#endif *outAudio.pq_fact = sub( *outAudio.pq_fact, Q2 ); move16(); } -- GitLab From 6bcc36cdaa171912e74a7cf23157cb50d5067b27 Mon Sep 17 00:00:00 2001 From: Markus Multrus Date: Wed, 1 Apr 2026 09:56:03 +0200 Subject: [PATCH 2/2] Empty-Commit -- GitLab