From b58f62ffe992257527fb5e303021519b29656a33 Mon Sep 17 00:00:00 2001 From: "Azizi, Arash" Date: Wed, 20 May 2026 10:31:16 +0200 Subject: [PATCH 1/2] issue 2594: creating the switch and fixing the false comments --- lib_com/options.h | 1 + lib_dec/ivas_stereo_ica_dec_fx.c | 9 +++++++++ 2 files changed, 10 insertions(+) diff --git a/lib_com/options.h b/lib_com/options.h index ac427455f..a94e91f98 100755 --- a/lib_com/options.h +++ b/lib_com/options.h @@ -112,6 +112,7 @@ #define HARMONIZE_2553_TonalConceal_Init /* FhG: Harmonize TonalMDCTConceal_Init with its ivas derivate */ #define HARMONIZE_2553_TonalConceal_SaveFreqSignal /* FhG: Harmonize TonalConceal_SaveFreqSignal with its ivas derivate */ #define HARMONIZE_2553_TonalConceal_SaveTimeSignal /* FhG: Harmonize TonalConceal_SaveTimeSignal with its ivas derivate */ +#define FIX_ISSUE_2594_FALSE_COMMENT /* FhG: basop issue 2594: fixing false comments about Q value*/ /* #################### End BE switches ################################## */ diff --git a/lib_dec/ivas_stereo_ica_dec_fx.c b/lib_dec/ivas_stereo_ica_dec_fx.c index 9345fccae..ddaeed981 100644 --- a/lib_dec/ivas_stereo_ica_dec_fx.c +++ b/lib_dec/ivas_stereo_ica_dec_fx.c @@ -436,11 +436,20 @@ void stereo_tca_scale_R_channel_fx( move32(); BREAK; case 32000: +#ifndef FIX_ISSUE_2594_FALSE_COMMENT winSlope_fx = 13421773; // 0.00625 in Q30 +#else + winSlope_fx = 13421773; // 0.00625 in Q31 +#endif // !FIX_ISSUE_2594_FALSE_COMMENT move32(); BREAK; case 48000: +#ifndef FIX_ISSUE_2594_FALSE_COMMENT winSlope_fx = 8947849; // 0.00416 in Q30 +#else + winSlope_fx = 8947849; // 0.00416 in Q31 +#endif // !FIX_ISSUE_2594_FALSE_COMMENT + move32(); BREAK; } -- GitLab From 29823e4a413c1a73f7e1fbd2535c37dd67f8fb34 Mon Sep 17 00:00:00 2001 From: "Azizi, Arash" Date: Wed, 20 May 2026 10:43:58 +0200 Subject: [PATCH 2/2] issue 2594: Clang formatting patch --- lib_dec/ivas_stereo_ica_dec_fx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib_dec/ivas_stereo_ica_dec_fx.c b/lib_dec/ivas_stereo_ica_dec_fx.c index ddaeed981..d88bdd3a9 100644 --- a/lib_dec/ivas_stereo_ica_dec_fx.c +++ b/lib_dec/ivas_stereo_ica_dec_fx.c @@ -440,7 +440,7 @@ void stereo_tca_scale_R_channel_fx( winSlope_fx = 13421773; // 0.00625 in Q30 #else winSlope_fx = 13421773; // 0.00625 in Q31 -#endif // !FIX_ISSUE_2594_FALSE_COMMENT +#endif // !FIX_ISSUE_2594_FALSE_COMMENT move32(); BREAK; case 48000: @@ -449,7 +449,7 @@ void stereo_tca_scale_R_channel_fx( #else winSlope_fx = 8947849; // 0.00416 in Q31 #endif // !FIX_ISSUE_2594_FALSE_COMMENT - + move32(); BREAK; } -- GitLab