Cleanup of pre-processor macros
# Basic info
<!--- Add commit SHA used to reproduce-->
- Float reference: ceb8871fb395dc677e0a02e8dba99d36074630c2 (Thu Mar 13 15:08:00 2025 +0000)
- Fixed point: 2d6aaa678e6290668751ad8a540f64aa125c67b3 (Tue Mar 18 11:55:13 2025 +0000)
These switches are present in the basop main in the version indicated above. The corresponding switch in ivas-float-update, if it exists, is listed in the right column. The plan is to clean out switches that are not necessary, from both main and ivas-float-update.
@all, please indicate if you want to keep the switch by clicking the check-mark. The target is to review this by Friday March 21st.
<table>
<tr>
<th>main</th>
<th>ivas-float-update</th>
</tr>
<tr>
<td>
* [ ] IVAS_FLOAT_FIXED_CONVERSIONS
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] MSAN_FIX
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_TMP_714
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] BASOP_NOGLOB_TMP_715
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] EVS_FUNC_MODIFIED
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] REMOVE_IVAS_UNUSED_PARAMETERS_WARNING
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] MOD_BIT_ALLOC_ROM_TABLE
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] SIMPLIFY_CODE_BE
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] CR_2109_to_2112_cd0_ce0
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_QMETADATA_PENALTY
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1013_CRASH_HQ_CORE_DEC
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] NONE_BE_FIX_BASOP_1044_OSBA_PRERENDER_MIX_GAINS
</td>
<td>
* [ ] NONE_BE_FIX_BASOP_1044_OSBA_PRERENDER_MIX_GAINS
</td>
</tr>
<tr>
<td>
* [ ] NONBE_1233_HQ_CLASSIFIER_DIV_BY_ZERO
</td>
<td>
* [ ] NONBE_1233_HQ_CLASSIFIER_DIV_BY_ZERO
</td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1062_AND_1068_TON_ENE_EST_FX
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_987
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1054_IF_ELSE_CMPLX
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1052_COPY_CMPLX_DISCREPANCY
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1049_SHR_RO_COMPLEXITY
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] NONBE_IMPROVE_DIRAC_INTENSITY_PREC
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1103_OPT_L_NORM_ARR
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1105_OPT_MINIMUM_SL
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1104_OPT_GETMINSCALEFAC
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1106_SIMPLIFY_SET32FX
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1107_VADDINC
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1009_OPT_PARAMMC_RENDER
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1109_OPTIM_MCT_STEREO_IGF_DEC
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1110_OPTIM_DIRAC_DECORR_PROC
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1127_IMPROVE_SBA_MLD
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1100_REMOVE_LPC_RESCALING
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1133_IMPROVE_MC_MLD
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1122
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1125
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1132_STACK_CORRUPTION
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1092
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1135
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1148
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1147
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1150
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1151
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1153
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1154
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1157
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1152
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1156
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_DISCLAIMER
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1167
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1009_REPLACE_DIV_SQRT_BY_ISQRT_LC
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1113_OPT_DIRAC_BIN_REND
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1187
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1186
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1165
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1185
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1209
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1218
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1290
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] IVAS_ISSUE_1188_EVS_CRASH
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1155
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1010_OPT_DIV
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1010_OPT_SINGLE_RESCALE
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1010_OPT_GIVENS
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1010_OPT_GIVENS_INV
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1010_OPT_NORM_NOSAT
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1010_OPT_SEC_SINGLE_RESCALE
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1072_SPEEDUP_matrixTransp2Mul_fx
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1072_REDUCE_DIVS
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1230
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] NONBE_1211_DTX_BR_SWITCHING
</td>
<td>
* [ ] NONBE_1211_DTX_BR_SWITCHING
</td>
</tr>
<tr>
<td>
* [ ] FIX_1189_GSC_IVAS_OMASA
</td>
<td>
* [ ] NONBE_FIX_1189_GSC_IVAS_OMASA
</td>
</tr>
<tr>
<td>
* [ ] NONBE_1273_ISM_METADATA_COUNTER
</td>
<td>
* [ ] NONBE_1273_ISM_METADATA_COUNTER
</td>
</tr>
<tr>
<td>
* [ ] NONBE_FIX_GSC_BSTR
</td>
<td>
* [ ] NONBE_FIX_GSC_BSTR
</td>
</tr>
<tr>
<td>
* [ ] FIX_1101_IVAS_SPAR_DEC_UPMIXER_SF
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] Note:
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1101_IVAS_SPAR_DEC_UPMIXER_SF_USE_MADD_ADD_WEIGHTS
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1101_IVAS_SPAR_DEC_UPMIXER_SF_SPLIT_LOOPS
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1101_IVAS_SPAR_DEC_UPMIXER_SF_HQ_CONSTANTS
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1101_IVAS_SPAR_DEC_UPMIXER_SF_USE_UNIQUE_SHL
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_11_1_IVAS_SPAR_DEC_UPMIXER_SF_RND_COEFFS
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1237
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1237_KEEP_EVS_BE
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1214
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_881_HILBERT_FILTER
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1245
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1291
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_920_IGF_INIT_ERROR
</td>
<td>
* [ ] FIX_920_IGF_INIT_ERROR
</td>
</tr>
<tr>
<td>
* [ ] FIX_MINOR_SVD_WMOPS_MR1010X
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_USAN_ISSUES
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] SVD_WMOPS_OPT
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] NONBE_FIX_1087_OOB_SBA_DTX_RS
</td>
<td>
* [ ] NONBE_FIX_1087_OOB_SBA_DTX_RS
</td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1279
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1247
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] NONBE_FIX_1087_OOB_SBA_DTX_RS
</td>
<td>Note: occurs twice in main</td>
</tr>
<tr>
<td>
* [ ] FIX_1285_DECODER_CRASH
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1072_SPEEDUP_gainpanning
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1072_SPEEDUP_COMPUTEDIFUSENESS
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1320_LOWRATE_ACELP
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1297_OVERFLOW
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1298
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1300_ICA_SHIFT_QUANT_IMPROV
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_1301_CORRECT_TD_CNST
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] NONBE_FIX_1277_EVS_DTX_HIGH_RATE_THRESHOLD
</td>
<td>
* [ ] NONBE_FIX_1277_EVS_DTX_HIGH_RATE_THRESHOLD
</td>
</tr>
<tr>
<td>
* [ ] NONBE_FIX_708_OSBA_BR_SWITCHING_CRASH
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] OPT_STEREO_32KBPS_V1
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] DOT_PROD_CHOLESKY_64BIT
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] OPT_BASOP_ADD_v1
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1327
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] NONBE_FIX_1402_WAVEADJUST
</td>
<td></td>
</tr>
<tr>
<td>
* [ ] SUPPORT_FORCE_TCX10_TCX20
</td>
<td>
* [ ] SUPPORT_FORCE_TCX10_TCX20
</td>
</tr>
<tr>
<td>
* [ ] FIX_ISSUE_1376
</td>
<td></td>
</tr>
</table>
The following switches are present in ivas-float-update in the version indicated above. These do not have any counterpart in the main, or at least none I could identify.
@all, please check the ones you would like to keep. The target is to review this by Friday March 21st.
<table>
<tr>
<th>ivas-float-update</th>
</tr>
<tr>
<td>
* [ ] NON_BE_FIX_1048_THRESHOLD_COH_BASOP
</td>
</tr>
<tr>
<td>
* [ ] NONBE_FIX_1054_NEGATIVE_LVQ_INDEX
</td>
</tr>
<tr>
<td>
* [ ] NONBE_FIX_738_QUATERNION_SLERP_PRECISION
</td>
</tr>
<tr>
<td>
* [ ] FIX_1033_MEMORY_LEAK_OMASA
</td>
</tr>
<tr>
<td>
* [ ] FIX_976_USAN_PVQ_ENC_DEC_EVS_CR
</td>
</tr>
<tr>
<td>
* [ ] FIX_1027_GSC_INT_OVERFLOW
</td>
</tr>
<tr>
<td>
* [ ] NONBE_FIX_1096_NAN_VALUES_IN_DIRAC_TO_STEREO
</td>
</tr>
<tr>
<td>
* [ ] NON_BE_1055_RESET_LP_MEMORIES
</td>
</tr>
<tr>
<td>
* [ ] NONBE_FIX_1069_SVD_TUNING
</td>
</tr>
<tr>
<td>
* [ ] NONBE_FIX_1010_STEREO_CNG_DIV_BY_ZERO
</td>
</tr>
<tr>
<td>
* [ ] NONBE_MDCT_ST_DTX_SKIP_DEWHITENING_OF_NOISE_SHAPES_ON_SID_FRAMES
</td>
</tr>
<tr>
<td>
* [ ] NONBE_MDCT_ST_PLC_DO_NOT_SCALE_OLD_OUT_IF_FIRST_GOOD_IS_SID
</td>
</tr>
<tr>
<td>
* [ ] NON_BE_FIX_1137_GSC_IVAS_FXFLT_DECODING
</td>
</tr>
<tr>
<td>
* [ ] NONBE_FIX_1132_THRESHOLD_POW_IN_SWB_TBE
</td>
</tr>
<tr>
<td>
* [ ] FIX_BASOP_812_NAN_COHSNR
</td>
</tr>
<tr>
<td>
* [ ] NON_BE_FIX_807_MASA_DTX_BRSW
</td>
</tr>
<tr>
<td>
* [ ] NON_BE_FIX_BASOP_819_THRESHOLD_MASA2TOTAL
</td>
</tr>
<tr>
<td>
* [ ] FIX_828_PORT_1152_FROM_FLT_REPO
</td>
</tr>
<tr>
<td>
* [ ] NONE_BE_FIX_816_LFE_PLC_FLOAT
</td>
</tr>
<tr>
<td>
* [ ] FIX_835_PARAMMC_BUFFER_VALUES
</td>
</tr>
<tr>
<td>
* [ ] NONBE_FIX_943_PORT_1208_DFT_STEREO_PLC_BURST
</td>
</tr>
<tr>
<td>
* [ ] FIX_903_ZERO_OUT_IMDCT_BUFFERS_FOR_MCT_IGNORE
</td>
</tr>
<tr>
<td>
* [ ] FIX_853_DECODE_MASA_ISM_AZIMUTH_PREC_FP
</td>
</tr>
<tr>
<td>
* [ ] NONBE_FIX_1205_TD_STEREO_MOD_CT
</td>
</tr>
<tr>
<td>
* [ ] NONBE_FIX_1213_SBA_DET_MAT_INV_3BY3
</td>
</tr>
<tr>
<td>
* [ ] NONBE_FIX_1204_MDCT_STEREO_NOISE_EST_SCALING
</td>
</tr>
<tr>
<td>
* [ ] NONBE_FIX_1189_GSC_IVAS_OMASA
</td>
</tr>
<tr>
<td>
* [ ] NONBE_FIX_708_OSBA_BR_SWITCHING_CRASH
</td>
</tr>
<tr>
<td>
* [ ] NONBE_1319_M2R_PRECISION_ALIGN
</td>
</tr>
<tr>
<td>
* [ ] BASOP_NOGLOB
</td>
</tr>
</table>
The following switches are present in main in the version indicated above. They are not in options.h, and the status of these is unclear. If they serve a purpose, I suggest they should be kept. If they are not used, they could be cleaned out.
@all, please check the ones you would like to keep. The target is to review this by Friday March 21st.
<table>
<tr>
<th>main</th>
</tr>
<tr>
<td>
* [ ] BASOP_NOGLOB_DECLARE_LOCAL
</td>
</tr>
<tr>
<td>
* [ ] REMOVE_IVAS_UNUSED_PARAMETERS_WARNING
</td>
</tr>
<tr>
<td>
* [ ] IVAS_CODE
</td>
</tr>
<tr>
<td>
* [ ] NEW_IVAS_OPEN_DEC
</td>
</tr>
<tr>
<td>
* [ ] IVAS_CODE_SWITCHING
</td>
</tr>
<tr>
<td>
* [ ] IVAS_CODE_CNG_FIX185_PLC_FADEOUT
</td>
</tr>
<tr>
<td>
* [ ] ADD_IVAS_HQ_CODE
</td>
</tr>
<tr>
<td>
* [ ] ADD_IVAS_HQ_CODE_L_SPEC
</td>
</tr>
<tr>
<td>
* [ ] ADD_IVAS_TBE_CODE
</td>
</tr>
<tr>
<td>
* [ ] ADD_IVAS_GS_DEC_IMPR
</td>
</tr>
<tr>
<td>
* [ ] ADD_IVAS_TNS
</td>
</tr>
<tr>
<td>
* [ ] ADD_IVAS_TBE_CODE
</td>
</tr>
<tr>
<td>
* [ ] ADD_IVAS_CLDFB
</td>
</tr>
<tr>
<td>
* [ ] SOLVED_COMP_ENC_DEC
</td>
</tr>
<tr>
<td>
* [ ] #if 0 … #endif
</td>
</tr>
<tr>
<td>
* [ ] #if 1 … #endif
</td>
</tr>
<tr>
<td>
* [ ] NON_BE_FIX_BASOP_819_THRESHOLD_MASA2TOTAL
</td>
</tr>
<tr>
<td>
* [ ] _DIFF_FLOAT_FIX_ PMT( "…" )
</td>
</tr>
</table>
issue