Possible porting error in TDREND_REND_RenderSourceHRFilt_fx
# Basic info <!--- Add commit SHA used to reproduce --> - Float reference: - Encoder (float): - Decoder (float): - Fixed point: - Encoder (fixed): - Decoder (fixed): 496d928d46719161bc5c05600fc4de510d684e6e # Bug description Looks like a clear porting error in TDREND_REND_RenderSourceHRFilt_fx, see below ```c /* Scaling prev and delta HRF filter values to common Q-factor */ Scale_sig32( Src_p->hrf_left_prev_fx, Src_p->filterlength, sub( Src_p->hrf_left_prev_e, left_filter_e ) ); Scale_sig32( hrf_left_delta_fx, Src_p->filterlength, sub( *hrf_left_delta_e, left_filter_e ) ); Scale_sig32( Src_p->hrf_right_prev_fx, Src_p->filterlength, sub( Src_p->hrf_right_prev_e, right_filter_e ) ); Scale_sig32( hrf_right_delta_fx, Src_p->filterlength, sub( *hrf_right_delta_e, left_filter_e ) ); <-- BUG HERE ``` It does not look like it would make sense to scale here with `left_filter_e` but of course it could be intentional. <!-- Commandline or script --> ```bash ``` <!--- Below are labels that will be added but are not shown in description. This is a template to help fill them. Add further information to the first row and remove and add labels as necessary. -->
issue