Probable porting bug in ivas_sba_dirac_stereo_compute_td_stefi_nrgs
# Basic info <!--- Add commit SHA used to reproduce --> - Float reference: - Encoder (float): - Decoder (float): 2a32cceaf0d7ce3482cb05e5c12951e95a8a552a - Fixed point: - Encoder (fixed): - Decoder (fixed): a8ff39cd03d151fa6c9a57b1d85de40c806f3772 # Bug description In beginning of function `ivas_sba_dirac_stereo_compute_td_stefi_nrgs`, there is probably porting bug where `output_frame/2` has become `output_frame/4`. See below Float ```c if ( ( core == ACELP_CORE && !fd_cng_flag ) || hStereoDft->core_hist[1] == ACELP_CORE ) { for ( i = 0; i < output_frame / 2; i++ ) { hb_nrg2 += hb_synth[i] * hb_synth[i]; } ``` BASOP ```c IF( ( EQ_16( core, ACELP_CORE ) && !fd_cng_flag ) || EQ_16( hStereoDft->core_hist[1], ACELP_CORE ) ) { FOR( i = 0; i < shr( output_frame, 2 ); i++ ) <-- BUG HERE { hb_nrg2 = Madd_32_32( hb_nrg2, hb_synth[i], hb_synth[i] ); /*2*q_hb_synth-31*/ } ``` It is always possible that there is some intentional change here so good to verify properly. And also good to check where this value is used. <!--- Below are labels that will be added but are not shown in description. This is a template to help fill them. Add further information to the first row and remove and add labels as necessary. -->
issue