Commit 0edcc82a authored by Jouni Paulus's avatar Jouni Paulus
Browse files

Merge branch '869-masa-pre-renderer-not-updating-energy-information-in-a-specific-case' into 'main' 

[Non-BE] Resolve #869: MASA pre-renderer not updating energy information in a specific case

See merge request !1275
parents dbb312a1 47eb3d52

lib_com/options.h

+2 −1
Original line number Diff line number Diff line
@@ -167,6 +167,7 @@ 
#define NONBE_FIX_908_OSBA_BR_SWITCHING_CRASH                 /* FhG: issue 908: fix crash in OSBA BR switching with long test vectors */

#define NONBE_FIX_BINAURAL_ROOM_IR_REVERBERATOR               /* FhG: re-enable acidentially disabled reverberator for BINAURAL_ROOM_IR */

#define NONBE_FIX_907_VLBR_DIRAC_BAND_MAPPING                 /* Dlb: issue 907: fix for band mapping at VLBR */

#define NONBE_FIX_869_MASA_PREREND_MERGE                      /* Nokia: issue: #869: MASA pre-rend not updating energy */



/* ##################### End NON-BE switches ########################### */

lib_rend/ivas_masa_merge.c

+30 −1
Original line number Diff line number Diff line
@@ -124,11 +124,19 @@ void copy_masa_descriptive_meta( 
 *---------------------------------------------------------------------*/



void diffuse_meta_merge_1x1(

#ifdef NONBE_FIX_869_MASA_PREREND_MERGE

    MASA_DECODER_EXT_OUT_META_HANDLE outMeta,                         /* o  : Merged metadata output                   */

    MASA_DECODER_EXT_OUT_META_HANDLE inMeta,                          /* i  : Input metadata 1                         */

    float inEne[MAX_PARAM_SPATIAL_SUBFRAMES][MASA_FREQUENCY_BANDS],   /* i/o: TF-energy of input 1. energy after merge */

    MASA_DECODER_EXT_OUT_META_HANDLE inMetaISM,                       /* i  : Input metadata 2                         */

    float inEneISM[MAX_PARAM_SPATIAL_SUBFRAMES][MASA_FREQUENCY_BANDS] /* i  : TF-energy of input 2                     */

#else

    MASA_DECODER_EXT_OUT_META_HANDLE outMeta,                         /* o  : Merged metadata output      */

    MASA_DECODER_EXT_OUT_META_HANDLE inMeta,                          /* i  : Input metadata 1            */

    float inEne[MAX_PARAM_SPATIAL_SUBFRAMES][MASA_FREQUENCY_BANDS],   /* i  : TF-energy of input 1        */

    MASA_DECODER_EXT_OUT_META_HANDLE inMetaISM,                       /* i  : Input metadata 2            */

    float inEneISM[MAX_PARAM_SPATIAL_SUBFRAMES][MASA_FREQUENCY_BANDS] /* i  : TF-energy of input 2        */

#endif

)

{

    int8_t sf, band;
@@ -276,6 +284,15 @@ void full_stream_merge( 
 *---------------------------------------------------------------------*/



void ivas_prerend_merge_masa_metadata(

#ifdef NONBE_FIX_869_MASA_PREREND_MERGE

    MASA_DECODER_EXT_OUT_META_HANDLE outMeta,                        /* o  : Merged metadata output                                                        */

    MASA_DECODER_EXT_OUT_META_HANDLE inMeta1,                        /* i  : Input metadata 1                                                              */

    IVAS_REND_AudioConfigType inType1,                               /* i  : Type of input 1                                                               */

    float inEne1[MAX_PARAM_SPATIAL_SUBFRAMES][MASA_FREQUENCY_BANDS], /* i/o: TF-energy of input 1. after merge, contains the energy of the merged signal   */

    MASA_DECODER_EXT_OUT_META_HANDLE inMeta2,                        /* i  : Input metadata 2                                                              */

    IVAS_REND_AudioConfigType inType2,                               /* i  : Type of input 2                                                               */

    float inEne2[MAX_PARAM_SPATIAL_SUBFRAMES][MASA_FREQUENCY_BANDS]  /* i  : TF-energy of input 2. may be altered                                          */

#else

    MASA_DECODER_EXT_OUT_META_HANDLE outMeta,                         /* o  : Merged metadata output                                                        */

    MASA_DECODER_EXT_OUT_META_HANDLE inMeta1,                         /* i  : Input metadata 1                                                              */

    IVAS_REND_AudioConfigType inType1,                                /* i  : Type of input 1                                                               */
@@ -283,13 +300,25 @@ void ivas_prerend_merge_masa_metadata( 
    MASA_DECODER_EXT_OUT_META_HANDLE inMeta2,                         /* i  : Input metadata 2                                                              */

    IVAS_REND_AudioConfigType inType2,                                /* i  : Type of input 2                                                               */

    float inEne2[MAX_PARAM_SPATIAL_SUBFRAMES][MASA_FREQUENCY_BANDS]   /* i  : TF-energy of input 2                                                          */

#endif

)

{

    /* mixing ISMs with non-ISM use different merge */

    if ( inType1 == IVAS_REND_AUDIO_CONFIG_TYPE_OBJECT_BASED && inType2 != IVAS_REND_AUDIO_CONFIG_TYPE_OBJECT_BASED && ( inMeta1->descriptiveMeta.numberOfDirections == 0u && inMeta2->descriptiveMeta.numberOfDirections == 0u ) )

    {

        /* meta_1 is ISM and both are 1dir */

#ifdef NONBE_FIX_869_MASA_PREREND_MERGE

        int8_t sf;



        diffuse_meta_merge_1x1( outMeta, inMeta2, inEne2, inMeta1, inEne1 ); /* post-merge energy is now in inEne2 and needs to be copied to inEne1 */



        for ( sf = 0; sf < MAX_PARAM_SPATIAL_SUBFRAMES; sf++ )

        {

            mvr2r( inEne2[sf], inEne1[sf], MASA_FREQUENCY_BANDS );

        }

#else

        diffuse_meta_merge_1x1( outMeta, inMeta2, inEne2, inMeta1, inEne1 );

#endif

    }

    else if ( inType2 == IVAS_REND_AUDIO_CONFIG_TYPE_OBJECT_BASED && inType1 != IVAS_REND_AUDIO_CONFIG_TYPE_OBJECT_BASED && ( inMeta1->descriptiveMeta.numberOfDirections == 0u && inMeta2->descriptiveMeta.numberOfDirections == 0u ) )

    {