Commit 15e1ca83 authored by Shikha Shetgeri's avatar Shikha Shetgeri
Browse files

address review comments

parent 40a34891

lib_com/options.h

+1 −1
Original line number Diff line number Diff line
@@ -187,7 +187,7 @@ 
#define COVARIANCE_MEMORY_OPT                           /* Dlb : Issue 231: define SPAR covariance buffers in stack instead of inter-frame heap */

#define NONBE_FIX_589_JBM_TC_OFFSETS                    /* FhG: issue 589: wrong offset into the TC buffers is used in some rendering paths in the JBM main rendering function */

#define FIX_MEM_REALLOC_IND_LIST                        /* VA: issue 601: failure of the automatic memory re-allocation mechanism when ind_list[] buffer is depleted in MASA mode with 2 TC*/

#define FIX_1720_HRTF_FASTCONV                          /* Dlb : Binaural format RAM saving in SBA mode */

#define FIX_1720_HRTF_FASTCONV                          /* Dlb : Binaural and Binaural room format RAM saving in SBA mode */

#define FIX_581_CLANG_OFFSET_TO_NULL                    /* FhG: issue 581: fix CLANG error about applying an offset to a NULL pointer */

#define JBM_PARAMUPMIX                                  /* Dlb: Issue 471: Integrate the Multichannel Parametric Upmix into the JBM path */

#define FIX_582_INDEX_OUT_OF_BOUNDS_SNS_AVQ_DEC         /* FhG: fix an undefined behaviour error in SNS AVQ decoding */

lib_dec/ivas_binRenderer_internal.c

+5 −4
Original line number Diff line number Diff line
@@ -1172,12 +1172,12 @@ ivas_error ivas_allocate_binaural_hrtf( 
 *-------------------------------------------------------------------------*/



static ivas_error ivas_binaural_hrtf_open(

    HRTFS_FASTCONV_HANDLE *hHrtfFastConv

    HRTFS_FASTCONV_HANDLE *hHrtfFastConv /* i : fastconv HRTF handle */

#ifdef FIX_1720_HRTF_FASTCONV

    ,

    AUDIO_CONFIG output_config,

    RENDERER_TYPE renderer_type,

    int8_t is_loudspeaker_setup

    AUDIO_CONFIG output_config,  /* i : output configuration */

    RENDERER_TYPE renderer_type, /* i : renderer type */

    int8_t is_loudspeaker_setup  /* i : loudspeaker setup information */

#endif

)

{
@@ -1228,6 +1228,7 @@ static ivas_error ivas_binaural_hrtf_open( 
        HrtfFastConv->FASTCONV_HOA2_latency_s = FASTCONV_HOA2_latency_s;

        HrtfFastConv->FASTCONV_FOA_latency_s = FASTCONV_FOA_latency_s;

        HrtfFastConv->FASTCONV_BRIR_latency_s = FASTCONV_BRIR_latency_s;



#endif

        for ( i = 0; i < BINAURAL_CONVBANDS; i++ )

        {