Commit 18e34398 authored by sbsarac's avatar sbsarac
Browse files

Review comments

parent 7b376011

apps/decoder.c

+2 −3
Original line number Diff line number Diff line
@@ -1835,9 +1835,8 @@ static void usage_dec( void ) 
    fprintf( stdout, "                      ISMs 1,2,3 and 4 respectively. This options needs to be accompanied by a render_config file,\n" );

    fprintf( stdout, "                      otherwise a default directivity pattern is used.\n" );

#ifdef FIX_1053_REVERB_RECONFIGURATION

    fprintf( stdout, "-aeid ID | File     : Acoustic environment ID (number > 0) or\n" );

    fprintf( stdout, "                      file contains lines for each ID and duration in the format [ID1:duration1] without braces and\n" );

    fprintf( stdout, "                      spaces, with ':' character separating ID from duration, where duration is specified in frames\n" );

    fprintf( stdout, "-aeid ID | File     : Acoustic environment ID (number > 0)\n" );

    fprintf( stdout, "                      alternatively, it can be a text file where each line contains \"ID duration\"\n" );

    fprintf( stdout, "                      for BINAURAL_ROOM_REVERB output configuration.\n" );

#else

    fprintf( stdout, "-aeid ID            : Acoustic environment ID (number >= 0) for BINAURAL_ROOM_REVERB output configuration\n" );

apps/renderer.c

+1 −1
Original line number Diff line number Diff line
@@ -403,7 +403,7 @@ static const CmdLnParser_Option cliOptions[] = { 
        .match = "acoustic_environment_id",

        .matchShort = "aeid",

#ifdef FIX_1053_REVERB_RECONFIGURATION

        .description = "Acoustic environment ID (number > 0) or file contains lines for each ID and duration in the format [ID1:duration1] without braces and spaces, with ':' character separating ID from duration, where duration is specified in frames for BINAURAL_ROOM_REVERB output configuration.",

        .description = "Acoustic environment ID (number > 0) alternatively, it can be a text file where each line contains \"ID duration\" for BINAURAL_ROOM_REVERB output configuration.",

#else

        .description = "Acoustic environment ID (number >= 0) for BINAURAL_ROOM_REVERB output configuration",

#endif

lib_util/aeid_file_reader.c

+2 −2
Original line number Diff line number Diff line
@@ -100,7 +100,7 @@ ivas_error aeidFileReading( 


    while ( !feof( aeidReader->aeidFile ) )

    {

        if ( fscanf( aeidReader->aeidFile, "%d:%d", &id, &duration ) == 2 )

        if ( fscanf( aeidReader->aeidFile, "%d %d", &id, &duration ) == 2 )

        {

            k++;

        }
@@ -129,7 +129,7 @@ ivas_error aeidFileReading( 


    while ( !feof( aeidReader->aeidFile ) )

    {

        if ( fscanf( aeidReader->aeidFile, "%d:%d", &id, &duration ) == 2 )

        if ( fscanf( aeidReader->aeidFile, "%d %d", &id, &duration ) == 2 )

        {

            ( *pID )[k] = (uint16_t) id;

            ( *pValidity )[k] = (uint16_t) duration;

readme.txt

+3 −5
Original line number Diff line number Diff line
@@ -287,8 +287,7 @@ Options: 
-dpid ID            : Directivity pattern ID(s) (space-separated list of up to 4 numbers can be 

                      specified) for binaural output configuration

-aeid ID | File     : Acoustic environment ID (number > 0) or

					  file contains lines for each ID and duration in the format [ID1:duration1] without braces and

					  spaces, with ':' character separating ID from duration, where duration is specified in frames

					  alternatively, it can be a text file where each line contains "ID duration"

					  for BINAURAL_ROOM_REVERB output configuration.					 

-level level        : Complexity level, level = (1, 2, 3), will be defined after characterisation.

-om File            : Coded metadata File for BINAURAL_SPLIT_PCM OutputConf
@@ -322,9 +321,8 @@ Options: 
-exof File          : External orientation trajectory File for simulation of external orientations

-dpid ID            : Directivity pattern ID(s) (space-separated list of up to 4 numbers can be 

                      specified) for binaural output configuration

-aeid ID | File     : Acoustic environment ID (number > 0) or

					  file contains lines for each ID and duration in the format [ID1:duration1] without braces and

					  spaces, with ':' character separating ID from duration, where duration is specified in frames

-aeid ID | File     : Acoustic environment ID (number > 0)

					  alternatively, it can be a text file where each line contains "ID duration"

					  for BINAURAL_ROOM_REVERB output configuration.

-lp Position        : Output LFE position. Comma-delimited triplet of [gain, azimuth, elevation] where gain is linear 

                      (like --gain, -g) and azimuth, elevation are in degrees.