Commit 1af1f798 authored by Archit Tamarapu's avatar Archit Tamarapu
Browse files

[renderer] 

- enabled support for BINAURAL_ROOM output
- fix a bug in ISM binaural rendering - position data was not copied for
  TD Object Renderer without headtracking
- fix differing crossfades for ambisonics to binaural with and without
  headrotation (changes BE for rotateFrame_sd() / rotateFrame_shd() calls)
- add initial version of delay compensation for LFE in binaural rendering
- fix support for raw PCM input
- CLI improvements, make some options required and edit the printout
- temporary fix for TD Renderer init bug
[pyaudio3dtools]
- various bugfixes
- update ISM binaural rendering for pyaudio3dtools to use nearest
  filter on sphere
[tests]
- don't xfail tests on a function level to avoid masking run errors
- enable per-testcase SNR thresholds and xfail tests accordingly instead
  of allowing them to pass
parent 7196c596

.gitlab-ci-custom.yml

+1 −1
Original line number Diff line number Diff line 
include:

  - project: $CUSTOM_CI_PROJECT

    ref: $CUSTOM_CI_REF

    ref: external-renderer-ci

    file: $CUSTOM_CI_FILE

.gitlab-ci.yml

+3 −3
Original line number Diff line number Diff line
@@ -232,7 +232,7 @@ external-renderer-make-pytest: 
  stage: test

  script:

    - make -j IVAS_rend

    - python3 -m pytest scripts/tests/test_renderer.py --capture=no --tb=no -n auto

    - python3 -m pytest scripts/tests/test_renderer.py -q --log-level ERROR -n auto



# test external renderer executable with cmake + asan

external-renderer-cmake-asan-pytest:
@@ -245,7 +245,7 @@ external-renderer-cmake-asan-pytest: 
    - python3 ci/disable_ram_counting.py

    - cmake -B cmake-build -G "Unix Makefiles" -DCLANG=asan -DCOPY_EXECUTABLES_TO_ROOT=true

    - cmake --build cmake-build -- -j

    - python3 -m pytest scripts/tests/test_renderer.py --capture=no --tb=no -n auto

    - python3 -m pytest scripts/tests/test_renderer.py -q --log-level ERROR -n auto



# test external renderer executable with cmake + msan

external-renderer-cmake-msan-pytest:
@@ -258,7 +258,7 @@ external-renderer-cmake-msan-pytest: 
    - python3 ci/disable_ram_counting.py

    - cmake -B cmake-build -G "Unix Makefiles" -DCLANG=msan  -DCOPY_EXECUTABLES_TO_ROOT=true

    - cmake --build cmake-build -- -j

    - python3 -m pytest scripts/tests/test_renderer.py --capture=no --tb=no -n auto

    - python3 -m pytest scripts/tests/test_renderer.py -q --log-level ERROR -n auto



# compare bit exactness between target and source branch

self-test-on-merge-request:

apps/renderer.c

+5 −2
Original line number Diff line number Diff line
@@ -1259,13 +1259,15 @@ static CmdlnArgs parseCmdlnArgs( int32_t argc, char **argv ) 
            .id = CmdLnOptionId_inputFile,

            .match = "input_file",

            .matchShort = "i",

            .isRequired = 1,

            .description = "Path to the input file",

        },

        {

            .id = CmdLnOptionId_inputFormat,

            .match = "input_format",

            .matchShort = "if",

            .description = "Format of input file",

            .isRequired = 1,

            .description = "Format of input file\nIn case of a metadata format this should be followed by a list of metadata file paths or NULL",

        },

        {

            .id = CmdLnOptionId_outputFile,
@@ -1278,6 +1280,7 @@ static CmdlnArgs parseCmdlnArgs( int32_t argc, char **argv ) 
            .id = CmdLnOptionId_outputFormat,

            .match = "output_format",

            .matchShort = "of",

            .isRequired = 1,

            .description = "Output format to render.\nAlternatively, can be a custom loudspeaker layout file",

        },

        {
@@ -1308,7 +1311,7 @@ static CmdlnArgs parseCmdlnArgs( int32_t argc, char **argv ) 
        {

            .id = CmdLnOptionId_noDiegeticPan,

            .match = "no_diegetic_pan",

            .matchShort = "ndl",

            .matchShort = "ndp",

            .description = "Panning mono no dietic sound to stereo -1<= pan <= 1\nleft or l or 1->left, right or r or -1->right, center or c or 0 ->middle",

        },

        {

lib_com/options.h

+3 −2
Original line number Diff line number Diff line
@@ -149,10 +149,11 @@ 


#define LBR_SBA_CORE_CODING_TUNING                      /* Contribution "3 Core Coder Tuning for low bitrate SBA with 2 TCs" */



#define FIX_WRONG_NBANDS_IN_ITD_ESTIMATION              /* Issue 85: fix incorrect setting of nbands in calc_mean_E_ratio() if bwidth is limited on commandline*/



#define EXT_RENDERER                                    /* FhG: external renderer library and standalone application */

#define FIX_EFAP_MATH                                   /* fix for EFAP: remove angle quantization and a bug in polygon lookup causing incorrect gains. minor tweak for ALLRAD. non-BE for modes using EFAP */



#define FIX_WRONG_NBANDS_IN_ITD_ESTIMATION              /* Issue 85: fix incorrect setting of nbands in calc_mean_E_ratio() if bwidth is limited on commandline*/



#define FIX_I87                                         /*  fix for issue 86: incorrect Ambisonics order set for head rotation in SBA */



/* ################## End DEVELOPMENT switches ######################### */

lib_dec/ivas_sba_dec.c

+0 −1
Original line number Diff line number Diff line
@@ -608,7 +608,6 @@ void ivas_sba_upmixer_renderer( 
        }

    }





    wmops_sub_end();



    return;