Commit 32f030f1 authored by Shikha Shetgeri's avatar Shikha Shetgeri
Browse files

address review comments

parent 0f487f6b

lib_com/ivas_prot.h

+5 −6
Original line number Diff line number Diff line
@@ -5047,12 +5047,11 @@ void ivas_binaural_hrtf_close( 
);



ivas_error ivas_allocate_binaural_hrtf(

    HRTFS_FASTCONV *HrtfFastConv,                                   /* i  : fastconv HRTF handle                       */

    AUDIO_CONFIG output_config,                                     /* i : ouput audio config                          */

    BINAURAL_INPUT_AUDIO_CONFIG output_config_bin,                  /* i : binaural input audio config                  */

    RENDERER_TYPE renderer_type,

    int8_t is_loudspeaker_setup,

    int16_t allocate_init_flag

    HRTFS_FASTCONV *HrtfFastConv,                               /* i/o: FASTCONV HRTF structure */

    AUDIO_CONFIG input_config,                                  /* i  : input audio configuration */

    BINAURAL_INPUT_AUDIO_CONFIG bin_input_config,               /* i : binaural input audio config */

    RENDERER_TYPE renderer_type,                                /* i : renderer type */

    int16_t allocate_init_flag                                  /* i  : Memory allocation flag  */

);

#endif

lib_dec/ivas_binRenderer_internal.c

+84 −584

File changed.

Preview size limit exceeded, changes collapsed.

lib_util/hrtf_file_reader.c

+1 −2
Original line number Diff line number Diff line
@@ -1059,7 +1059,7 @@ static ivas_error create_fastconv_HRTF_from_rawdata( 
#ifdef FIX_1720_HRTF_FASTCONV

    ( *hHRTF )->input_cfg_var = input_cfg;

    ( *hHRTF )->allocate_init_flag = 0;

    ivas_allocate_binaural_hrtf( *hHRTF, 0, input_cfg, rend_type, 0, ( *hHRTF )->allocate_init_flag );

    ivas_allocate_binaural_hrtf( *hHRTF, 0, input_cfg, rend_type, ( *hHRTF )->allocate_init_flag );

#endif



    // if ( hHRTF == NULL )
@@ -1436,7 +1436,6 @@ static ivas_error create_fastconv_HRTF_from_rawdata( 


        for ( i = 0; i < BINAURAL_CONVBANDS; i++ )

        {

            /*here it seems to be always execting HRTF_LS_CHANNELS channels*/

            for ( j = 0; j < HRTF_LS_CHANNELS; j++ )

            {

                memcpy( ( *hHRTF )->leftBRIRReal[i][j], hrtf_data_rptr, BINAURAL_NTAPS_MAX * sizeof( float ) );