Commit 53465924 authored by norvell's avatar norvell
Browse files

Merge branch... 

Merge branch 'float-1483-clang18-msan-use-of-uninitialized-value-in-lib_enc-peak_vq_enc-c-268-5' into 'main'

Add fix FIX_1483_PEAQ_VQ_ENC_MSAN_ERROR to address MSAN error

See merge request !2470
parents fdd900f5 06e813a1

lib_com/hvq_pvq_bitalloc.c

+6 −0
Original line number Diff line number Diff line
@@ -80,6 +80,10 @@ int16_t hvq_pvq_bitalloc( 
    int16_t num_sfm;

    int16_t bit_cost;



#ifdef FIX_1483_PEAQ_VQ_ENC_MSAN_ERROR

    *n_sel_bands = 0;

#endif



    if ( bwidth == FB )

    {

        num_sfm = SFM_N_HARM_FB;
@@ -134,7 +138,9 @@ int16_t hvq_pvq_bitalloc( 
        return 0;

    }



#ifndef FIX_1483_PEAQ_VQ_ENC_MSAN_ERROR

    *n_sel_bands = 0;

#endif

    env_mean = 0;

    E_max = 0;

    k_max = k_start;

lib_com/options.h

+1 −0
Original line number Diff line number Diff line
@@ -174,6 +174,7 @@ 
#define FIX_2268_OOB_INDEXING_IN_IFFT                   /* VA: Fix for issue 2268, to silence clang18 */

#define FIX_2271_OOB_INDEXING_IN_PIT_OL2                /* VA: Fix for issue 2271, to silence clang18 */

#define FIX_2273_OOB_INDEXING_IN_PIT_FR4                /* VA: Fix to silence clang on ptr init */

#define FIX_1483_PEAQ_VQ_ENC_MSAN_ERROR                 /* Eri: When no PVQ bands are selected in peaq_vq_enc, the number of bands is not initialized. */

#define FIX_1480_CLANG18_MSAN_UNINIT_VARIABLE           /* Eri: Initializes a variable in HQ decoder. It is not used, but is passed uninitialized to a function which is caught by clang-18 */

#define FIX_1449_RENDERER_FRAME_SIZE_UNCLEAR_IN_ISAR    /* Dolby: Fix for issue 1449: renderer frame size unclear in ISAR */

#define FIX_1478_UNINIT_ON_BFI                          /* VA: Fix issue 1478 where a vector is partly un-initialized during bfi */