Commit 6faa1109 authored by vaclav's avatar vaclav
Browse files

accept NONBE_1300_TDREND_LARGE_ITD and NONBE_1293_SR_HRTF

parent fdb264b7

apps/decoder.c

+0 −4
Original line number Diff line number Diff line
@@ -298,11 +298,7 @@ int main( 
    if ( arg.hrtfReaderEnabled )

    {

        /* sanity check */

#ifdef NONBE_1293_SR_HRTF

        if ( arg.outputConfig != IVAS_AUDIO_CONFIG_BINAURAL && arg.outputConfig != IVAS_AUDIO_CONFIG_BINAURAL_ROOM_IR && arg.outputConfig != IVAS_AUDIO_CONFIG_BINAURAL_ROOM_REVERB && arg.outputConfig != IVAS_AUDIO_CONFIG_BINAURAL_SPLIT_CODED && arg.outputConfig != IVAS_AUDIO_CONFIG_BINAURAL_SPLIT_PCM )

#else

        if ( arg.outputConfig != IVAS_AUDIO_CONFIG_BINAURAL && arg.outputConfig != IVAS_AUDIO_CONFIG_BINAURAL_ROOM_IR && arg.outputConfig != IVAS_AUDIO_CONFIG_BINAURAL_ROOM_REVERB )

#endif

        {

            arg.hrtfReaderEnabled = false;

            fprintf( stderr, "\nError: HRTF binary file cannot be used in this output configuration.\n\n" );

lib_com/options.h

+0 −2
Original line number Diff line number Diff line
@@ -171,8 +171,6 @@ 


#define NONBE_1244_FIX_SWB_BWE_MEMORY                   /* VA: issue 1244: fix to SWB BWE memory in case of switching from FB coding - pending a review by Huawei */ 

#define NONBE_1122_KEEP_EVS_MODE_UNCHANGED              /* FhG: Disables fix for issue 1122 in EVS mode to keep BE tests green. This switch should be removed once the 1122 fix is added to EVS via a CR.  */

#define NONBE_1300_TDREND_LARGE_ITD                     /* Eri: issue 1300: There was a bug feeding 1.25 ms frames to the TD renderer, causing out-of-buffer access. This was resolved. However, it is still possible that modeled HRTF with large ITDs could trigger out-of-buffer access. This adds a check to prevent this.*/

#define NONBE_1293_SR_HRTF                              /* VA: issue 1293: add support of external HRTFs in split rendering */



/* ##################### End NON-BE switches ########################### */

lib_rend/ivas_objectRenderer.c

+1 −4
Original line number Diff line number Diff line
@@ -437,9 +437,7 @@ ivas_error TDREND_GetMix( 
    float hrf_left_delta[SFX_SPAT_BIN_MAX_FILTER_LENGTH];

    float hrf_right_delta[SFX_SPAT_BIN_MAX_FILTER_LENGTH];

    int16_t intp_count;

#ifdef NONBE_1300_TDREND_LARGE_ITD

    int16_t currShift, prevShift, transition_len, length_in2;

#endif



    error = IVAS_ERR_OK;
@@ -465,7 +463,7 @@ ivas_error TDREND_GetMix( 
        {

            TDREND_SRC_REND_UpdateFiltersFromSpatialParams( hBinRendererTd, SrcRend_p, SrcSpatial_p, Src_p->hrf_left_prev,

                                                            Src_p->hrf_right_prev, hrf_left_delta, hrf_right_delta, &intp_count, &Src_p->filterlength, &Src_p->itd, &Src_p->Gain, Src_p );

#ifdef NONBE_1300_TDREND_LARGE_ITD



            /* For large ITD values at lower sampling rate, check if the transition can be done */

            if ( Src_p->itd * Src_p->previtd < 0 )

            {
@@ -479,7 +477,6 @@ ivas_error TDREND_GetMix( 
                    Src_p->itd = 0;

                }

            }

#endif

        }



        /* Render source if needed */