Commit 7a280f5a authored by vaillancour's avatar vaillancour
Browse files

Merge branch 'float-2252-msan-with-bitstream-that-starts-with-an-sid' into 'main' 

Resolve "MSAN with bitstream that starts with an SID"

See merge request !2439
parents a1482804 a3e05b4e

lib_com/options.h

+1 −1
Original line number Diff line number Diff line
@@ -171,7 +171,7 @@ 
#define FIX_1435_MOVE_STEREO_PANNING                    /* VA: issue 1435: do the EVS stereo panning in the renderer */

#define FIX_1454_FIX_STEREO_TO_FOA_JBM                  /* VA: issue 1454: fix buggy stereo to FOA in JBM */

#define FIX_1461_CNG_BW_SWITCHING                       /* Eri: issue 1461: Stereo parameters are not updated when SID/NODATA forces BW to stay the same */



#define FIX_2252_LP_CNG_STARTS_SID                      /* VA: issues 2251 and 2252: fix LP CNG uninitialized value in bitstream that starts with an SID */



/* ##################### End NON-BE switches ########################### */

lib_dec/decision_matrix_dec.c

+4 −0
Original line number Diff line number Diff line
@@ -101,6 +101,10 @@ void decision_matrix_dec( 
                    if ( get_next_indice( st, 1 ) == 1 )

                    {

                        st->L_frame = L_FRAME16k;

#ifdef FIX_2252_LP_CNG_STARTS_SID

                        st->nb_subfr = NB_SUBFR16k;

                        st->bwidth = max( st->bwidth, WB );

#endif

                    }

                }

                else

lib_dec/init_dec.c

+18 −0
Original line number Diff line number Diff line
@@ -79,8 +79,26 @@ ivas_error init_decoder( 
    st->last_total_brate_ber = -1;

    st->core_brate = ACELP_8k00;

    st->ini_frame = 0;

#ifdef FIX_2252_LP_CNG_STARTS_SID

    if ( st->element_mode == EVS_MONO )

    {

        st->bwidth = NB;

        st->last_bwidth = NB;

    }

    else

    {

#if 0 // keep deactivated for the moment to keep BE

        st->bwidth = WB;

        st->last_bwidth = WB;

#else

        st->bwidth = NB;

        st->last_bwidth = NB;

#endif

    }

#else

    st->bwidth = NB;

    st->last_bwidth = NB;

#endif

    st->extl_brate = 0;



    st->coder_type = GENERIC;

lib_dec/ivas_decision_matrix_dec.c

+4 −0
Original line number Diff line number Diff line
@@ -95,6 +95,10 @@ void ivas_decision_matrix_dec( 
            if ( get_next_indice( st, 1 ) )

            {

                st->L_frame = L_FRAME16k;

#ifdef FIX_2252_LP_CNG_STARTS_SID

                st->nb_subfr = NB_SUBFR16k;

                st->bwidth = max( st->bwidth, WB );

#endif

            }

            else

            {