Commit 9494caf0 authored by Archit Tamarapu's avatar Archit Tamarapu
Browse files

[fix] wrong variable used in tests + missing TODO

parent cbff7207

lib_rend/ivas_rotation.c

+0 −3
Original line number Diff line number Diff line
@@ -1688,10 +1688,7 @@ void external_target_interpolation( 
#ifdef API_5MS

            if ( hExtOrientationData->enableExternalOrientation )

            {

                // TODO tmu2bay, tmu2pajunen : is this correct or should we use one of the other options?

                // hCombinedOrientationData->Quaternions_ext_interpolation_start = hExtOrientationData->Quaternion;

                hCombinedOrientationData->Quaternions_ext_interpolation_start = hCombinedOrientationData->Quaternion_prev_extOrientation;

                // hCombinedOrientationData->Quaternions_ext_interpolation_start = hCombinedOrientationData->Quaternion_frozen_ext;

            }

#else

            if ( hExtOrientationData->enableExternalOrientation[i] == 1 )

tests/split_rendering/test_split_rendering.py

+9 −3
Original line number Diff line number Diff line
@@ -41,9 +41,13 @@ def check_xfail(test_info, in_fmt, render_config, bitrate=None): 
        and "0dof" in render_config

        and (

            "lc3plus" in render_config

            or (in_fmt in INPUT_FORMATS_ISM_SPLIT_REND or in_fmt in INPUT_FORMATS_MC_SPLIT_REND)

            or (

                "external_split" in test_info.node.name and in_fmt in INPUT_FORMATS_AMBI_SPLIT_REND

                in_fmt in INPUT_FORMATS_ISM_SPLIT_REND

                or in_fmt in INPUT_FORMATS_MC_SPLIT_REND

            )

            or (

                "external_split" in test_info.node.name

                and in_fmt in INPUT_FORMATS_AMBI_SPLIT_REND

            )  # CREND for external renderer ambisonics rendering uses LC3plus by default

        )

    ):
@@ -214,7 +218,7 @@ def test_masa_full_chain_split(test_info, in_fmt, bitrate, render_config, trajec 


@pytest.mark.parametrize("trajectory", SPLIT_REND_HR_TRAJECTORIES_TO_TEST)

@pytest.mark.parametrize("render_config", RENDERER_CONFIGS_TO_TEST_MASA)

@pytest.mark.parametrize("in_fmt", INPUT_FORMATS_MASA)

@pytest.mark.parametrize("in_fmt", INPUT_FORMATS_MASA_SPLIT_REND)

def test_masa_external_split(test_info, in_fmt, render_config, trajectory):

    check_xfail(test_info, in_fmt, render_config)
@@ -263,6 +267,7 @@ full_chain_split_pcm_params = [ 
    # ("MASA2", "256000", "split_renderer_config_3dof_384k_lcld"),

]





@pytest.mark.parametrize("in_fmt,bitrate,render_config", full_chain_split_pcm_params)

def test_full_chain_split_pcm(test_info, in_fmt, bitrate, render_config):

    check_xfail(test_info, in_fmt, render_config, bitrate)
@@ -288,6 +293,7 @@ external_split_pcm_params = [ 
    ("ISM1", "split_renderer_config_3dof_384k_lcld"),

]





@pytest.mark.parametrize("in_fmt,render_config", external_split_pcm_params)

def test_external_split_pcm(test_info, in_fmt, render_config):

    check_xfail(test_info, in_fmt, render_config)

tests/split_rendering/test_split_rendering_be_comparison.py

+3 −1
Original line number Diff line number Diff line
@@ -187,7 +187,7 @@ def test_masa_full_chain_split(test_info, in_fmt, bitrate, render_config, trajec 


@pytest.mark.parametrize("trajectory", SPLIT_REND_HR_TRAJECTORIES_TO_TEST)

@pytest.mark.parametrize("render_config", RENDERER_CONFIGS_TO_TEST_MASA)

@pytest.mark.parametrize("in_fmt", INPUT_FORMATS_MASA)

@pytest.mark.parametrize("in_fmt", INPUT_FORMATS_MASA_SPLIT_REND)

def test_masa_external_split(test_info, in_fmt, render_config, trajectory):

    check_xfail(test_info, in_fmt, render_config)
@@ -236,6 +236,7 @@ full_chain_split_pcm_params = [ 
    # ("MASA2", "256000", "split_renderer_config_3dof_384k_lcld"),

]





@pytest.mark.parametrize("in_fmt,bitrate,render_config", full_chain_split_pcm_params)

def test_full_chain_split_pcm(test_info, in_fmt, bitrate, render_config):

    check_xfail(test_info, in_fmt, render_config, bitrate)
@@ -261,6 +262,7 @@ external_split_pcm_params = [ 
    ("ISM1", "split_renderer_config_3dof_384k_lcld"),

]





@pytest.mark.parametrize("in_fmt,render_config", external_split_pcm_params)

def test_external_split_pcm(test_info, in_fmt, render_config):

    check_xfail(test_info, in_fmt, render_config)