Commit 9ce21a9d authored by Dominik Weckbecker's avatar Dominik Weckbecker 💬
Browse files

rename define CR_FIX_736_FOA_BR_SWITCH to NONBE_FIX_736_FOA_BR_SWITCH

parent fb1fd40b

lib_com/options.h

+1 −0
Original line number Diff line number Diff line
@@ -165,6 +165,7 @@ 
/* any switch which is non-be wrt selection floating point code */

/* all switches in this category should start with "NONBE_" */



#define NONBE_FIX_736_FOA_BR_SWITCH                           /* FhG/Dlb : Issue 736: FOA bitrate switching decoding crashes in in ivas_spar_to_dirac */

#define NONBE_FIX_746_NONDIEGETIC_MD                          /* Eri: Issue 746: The non-diegetic panning flag affects the encoder bitstream even if extended metadata is not enabled. Crashes the decoder.*/



/* ##################### End NON-BE switches ############################# */

lib_dec/ivas_sba_dec.c

+7 −7
Original line number Diff line number Diff line
@@ -183,7 +183,7 @@ ivas_error ivas_sba_dec_reconfigure( 


    if ( hSpar != NULL )

    {

#ifdef CR_FIX_736_FOA_BR_SWITCH

#ifdef NONBE_FIX_736_FOA_BR_SWITCH

        if ( ( hSpar->hPCA != NULL ) && ( ( hDecoderConfig->ivas_total_brate != PCA_BRATE ) || ( st_ivas->sba_order != 1 ) ) )

#else

        if ( ( hSpar->hPCA != NULL ) && ( ( hDecoderConfig->ivas_total_brate != PCA_BRATE ) || ( sba_order_internal != 1 ) ) )
@@ -218,7 +218,7 @@ ivas_error ivas_sba_dec_reconfigure( 
                return error;

            }

        }

#ifdef CR_FIX_736_FOA_BR_SWITCH

#ifdef NONBE_FIX_736_FOA_BR_SWITCH

        if ( ( hSpar->hPCA == NULL ) &&

             ( st_ivas->hDecoderConfig->ivas_total_brate == PCA_BRATE && st_ivas->sba_order == 1 ) && ( st_ivas->ivas_format == SBA_FORMAT ) )

        {
@@ -289,13 +289,13 @@ ivas_error ivas_sba_dec_reconfigure( 
    {

        ivas_binRenderer_close( &st_ivas->hBinRenderer );

    }

#ifdef CR_FIX_736_FOA_BR_SWITCH

#ifdef NONBE_FIX_736_FOA_BR_SWITCH

    if ( ( error = ivas_dirac_sba_config( st_ivas->hQMetaData, &st_ivas->element_mode_init, ivas_total_brate, st_ivas->sba_analysis_order, ivas_get_hodirac_flag( ivas_total_brate, st_ivas->sba_analysis_order ) ? IVAS_MAX_NUM_BANDS : ( IVAS_MAX_NUM_BANDS - SPAR_DIRAC_SPLIT_START_BAND ) ) ) != IVAS_ERR_OK )

    {

        return error;

    }

#endif

#ifndef CR_FIX_736_FOA_BR_SWITCH

#ifndef NONBE_FIX_736_FOA_BR_SWITCH

    if ( ( ( st_ivas->renderer_type != RENDERER_DISABLE ) && ( st_ivas->renderer_type != RENDERER_SBA_LINEAR_DEC ) ) || ( ( hDecoderConfig->output_config != AUDIO_CONFIG_FOA ) && ( st_ivas->hDecoderConfig->output_config != AUDIO_CONFIG_STEREO ) && ( st_ivas->hDecoderConfig->output_config != AUDIO_CONFIG_MONO ) ) || ( last_ivas_total_brate > IVAS_256k && ivas_total_brate <= IVAS_256k ) || ( last_ivas_total_brate <= IVAS_256k && ivas_total_brate > IVAS_256k ) )

#else

    if ( ( ( st_ivas->renderer_type != RENDERER_DISABLE ) && ( st_ivas->renderer_type != RENDERER_SBA_LINEAR_DEC ) ) || ( ( hDecoderConfig->output_config != AUDIO_CONFIG_FOA ) && ( st_ivas->hDecoderConfig->output_config != AUDIO_CONFIG_STEREO ) && ( st_ivas->hDecoderConfig->output_config != AUDIO_CONFIG_MONO ) ) )
@@ -324,17 +324,17 @@ ivas_error ivas_sba_dec_reconfigure( 
            mvs2s( st_ivas->hTcBuffer->subframe_nbslots, st_ivas->hSpatParamRendCom->subframe_nbslots, MAX_JBM_SUBFRAMES_5MS );

        }

    }

#ifdef CR_FIX_736_FOA_BR_SWITCH

#ifdef NONBE_FIX_736_FOA_BR_SWITCH

    else

    {

#endif

#ifndef CR_FIX_736_FOA_BR_SWITCH

#ifndef NONBE_FIX_736_FOA_BR_SWITCH

        if ( ( error = ivas_dirac_sba_config( st_ivas->hQMetaData, &st_ivas->element_mode_init, ivas_total_brate, st_ivas->sba_analysis_order, ivas_get_hodirac_flag( ivas_total_brate, st_ivas->sba_analysis_order ) ? IVAS_MAX_NUM_BANDS : ( IVAS_MAX_NUM_BANDS - SPAR_DIRAC_SPLIT_START_BAND ) ) ) != IVAS_ERR_OK )

        {

            return error;

        }

#endif

#ifdef CR_FIX_736_FOA_BR_SWITCH

#ifdef NONBE_FIX_736_FOA_BR_SWITCH

        int16_t band_grouping[IVAS_MAX_NUM_BANDS + 1];



        st_ivas->hSpar->enc_param_start_band = min( IVAS_MAX_NUM_BANDS, SPAR_DIRAC_SPLIT_START_BAND );