Commit b115aae8 authored by Jan Kiene's avatar Jan Kiene
Browse files

harmonize MAXIMUM ABS DIFF -> MAX_ABS_DIFF

parent c7a36b9c

ci/basop-pages/create_report_pages.py

+1 −1
Original line number Diff line number Diff line
@@ -104,7 +104,7 @@ COLUMNS = [ 
    "Category",

    "Result",

    "MLD",

    "MAXIMUM ABS DIFF",

    "MAX_ABS_DIFF",

    "MIN_SSNR",

    "MIN_ODG",

]

tests/cmp_pcm.py

+3 −3
Original line number Diff line number Diff line
@@ -85,7 +85,7 @@ def cmp_pcm( 
            f"file 2 = {s2.shape[0]}",

            file=output_target,

        )

        reason = "FAIL: File lengths differ. MAXIMUM ABS DIFF: None"

        reason = "FAIL: File lengths differ. MAX_ABS_DIFF: None"

        if get_mld:

            reason += " - MLD: None"
@@ -119,12 +119,12 @@ def cmp_pcm( 
        if not cmp_result["bitexact"] and cmp_result["max_abs_diff"] <= abs_tol:

            reason = "SUCCESS: Maximum absolute diff below threshold"

        elif not cmp_result["bitexact"]:

            diff_msg = f"MAXIMUM ABS DIFF ==> {cmp_result['max_abs_diff']} at sample num {cmp_result['max_abs_diff_pos_sample']} (assuming {nchannels} channels)"

            diff_msg = f"MAX_ABS_DIFF ==> {cmp_result['max_abs_diff']} at sample num {cmp_result['max_abs_diff_pos_sample']} (assuming {nchannels} channels)"

            first_msg = f"First diff found at sample num {cmp_result['first_diff_pos_sample']} in channel {cmp_result['first_diff_pos_channel']}, frame {cmp_result['first_diff_pos_frame']} (assuming {nchannels} channels, {fs} sampling rate)"

            print(diff_msg, file=output_target)

            print(first_msg, file=output_target)



            reason = f"Non-BE - MAXIMUM ABS DIFF: {cmp_result['max_abs_diff']}"

            reason = f"Non-BE - MAX_ABS_DIFF: {cmp_result['max_abs_diff']}"

            output_differs = 1



        if get_mld:

tests/constants.py

+1 −1
Original line number Diff line number Diff line
@@ -23,7 +23,7 @@ DMX_SSNR = "DMX_SSNR" 


# regex patterns for parsing the output from comparisons -> mainly for BASOP ci

MLD_PATTERN = r"MLD: ([\d\.]*)"

MAX_DIFF_PATTERN = r"MAXIMUM ABS DIFF: (\d*)"

MAX_DIFF_PATTERN = r"MAX_ABS_DIFF: (\d*)"

ODG_PATTERN_PQEVALAUDIO = r"Objective Difference Grade: (-*\d*\.\d*)"

ODG_PATTERN = r"(?<!Delta-)ODG: (-*\d*\.\d*)"

DELTA_ODG_PATTERN = r"Delta-ODG: (-?\d*\.\d+)"