add more testcases to cover all paths