Commit eef03f9d authored by vaclav's avatar vaclav
Browse files

Merge branch 'revision_of_todos' into 'main' 

Revision of todos

See merge request !627
parents c7f3151e 0a2166ca

apps/renderer.c

+1 −1
Original line number Diff line number Diff line
@@ -230,7 +230,7 @@ static const CmdLnParser_Option cliOptions[] = { 
        .id = CmdLnOptionId_sampleRate,

        .match = "sample_rate",

        .matchShort = "fs",

        .description = "Input sampling rate in kHz (16, 32, 48) - required only with raw PCM inputs", /* TODO(sgi): Add sampling rate to scene description files */

        .description = "Input sampling rate in kHz (16, 32, 48) - required only with raw PCM inputs",

    },

    {

        .id = CmdLnOptionId_trajFile,

lib_com/core_com_config.c

+0 −1
Original line number Diff line number Diff line
@@ -742,7 +742,6 @@ void init_tcx_window_cfg( 
    hTcxCfg->tcx_mdct_window_min_length = (int16_t) ( sr_core * INV_CLDFB_BANDWIDTH );

    hTcxCfg->tcx_mdct_window_min_lengthFB = (int16_t) ( input_Fs * INV_CLDFB_BANDWIDTH );

    /* save complexity by copying the small windows if they have the same length */

    /* TODO: is this always the case ? */

    if ( hTcxCfg->tcx_mdct_window_min_length == hTcxCfg->tcx_mdct_window_trans_length )

    {

        mvr2r( hTcxCfg->tcx_mdct_window_trans, hTcxCfg->tcx_mdct_window_minimum, hTcxCfg->tcx_mdct_window_min_length );

lib_com/ivas_error.h

+2 −2
Original line number Diff line number Diff line
@@ -56,7 +56,7 @@ typedef enum 
    IVAS_ERR_INVALID_SAMPLING_RATE,

    IVAS_ERR_NOT_CONFIGURED,

    IVAS_ERR_INVALID_STEREO_MODE,

    IVAS_ERR_INVALID_CICP_INDEX, /* ToDo: rename, CICP not used in IVAS anymore */

    IVAS_ERR_INVALID_MC_LAYOUT,

    IVAS_ERR_INVALID_BITRATE,

    IVAS_ERR_INVALID_MASA_CONFIG,

    IVAS_ERR_TOO_MANY_INPUTS,
@@ -193,7 +193,7 @@ static inline const char *ivas_error_to_string( ivas_error error_code ) 
            return "Handle has not been configured";

        case IVAS_ERR_INVALID_STEREO_MODE:

            return "Invalid stereo mode";

        case IVAS_ERR_INVALID_CICP_INDEX:

        case IVAS_ERR_INVALID_MC_LAYOUT:

            return "Invalid speaker layout";

        case IVAS_ERR_INVALID_BITRATE:

            return "Invalid bitrate";

lib_dec/dec_tcx.c

+1 −1
Original line number Diff line number Diff line
@@ -1742,7 +1742,7 @@ void decoder_tcx_imdct( 


        if ( st->element_mode > EVS_MONO )

        {

            st->old_fpitchFB = st->old_fpitch * (float) L_frameTCX_glob / (float) L_frame_glob; /* TODO - or maybe used min(L_frame_TCX,L_FRAME48k) ... */

            st->old_fpitchFB = st->old_fpitch * (float) L_frameTCX_glob / (float) L_frame_glob;

        }

        else

        {

lib_dec/ivas_dirac_decorr_dec.c

+1 −1
Original line number Diff line number Diff line
@@ -156,7 +156,7 @@ ivas_error ivas_dirac_dec_decorr_open( 
        freq_domain_decorr_ap_params->max_frequency = ( DIRAC_MAX_DECORR_CLDFB_BANDS * 24000 ) / CLDFB_NO_CHANNELS_MAX;

    }



    freq_domain_decorr_ap_params->use_ducker = 1; /* ToDo: fcs: fixed for now but can be adaptive in an extended version */

    freq_domain_decorr_ap_params->use_ducker = 1;



    assert( ( freq_domain_decorr_ap_params->max_frequency >= 0 ) && ( freq_domain_decorr_ap_params->max_frequency <= output_Fs / 2 ) && "Error: max_frequency invalid!" );