Commit f1805395 authored by vaclav's avatar vaclav
Browse files

Merge branch '1386-msan-clang-18-use-of-uninitialized-value-in-ivas_spar_dec_open' into 'main' 

Fix [MSAN Clang 18] use-of-uninitialized value in ivas_spar_dec_open

See merge request !2261
parents 734e272c abdf17d1

lib_com/ivas_cnst.h

+3 −0
Original line number Diff line number Diff line
@@ -229,6 +229,9 @@ typedef enum 
/* format signaling in SID frames */

#define SID_FORMAT_NBITS                        3                           /* Bit 0 | Bit 1 | Bit 2 */

                                                                            /*-------|-------|------ */

#ifdef FIX_1384_MSAN_ivas_spar_dec_open

#define SID_FORMAT_NONE                         (-0x1)                      /*    n/a|    n/a|    n/a*/

#endif

#define SID_DFT_STEREO                          0x0                         /*      0|      0|     0 */

#define SID_MDCT_STEREO                         0x1                         /*      1|      0|     0 */

#define SID_ISM                                 0x2                         /*      0|      1|     0 */

lib_com/options.h

+1 −0
Original line number Diff line number Diff line
@@ -166,6 +166,7 @@ 
#define TMP_1342_WORKAROUND_DEC_FLUSH_BROKEN_IN_SR      /* FhG: Temporary workaround for incorrect implementation of decoder flush with split rendering */

#define FIX_1377_HANDLE_ERROR_CODE                      /* Eri: Add missing error code handling from IVAS_REND_SetObjectIDs */

#define FIX_HRTF_LEFTOVERS                              /* VA: HRTF updates - bring float main in line with BASOP main */

#define FIX_1384_MSAN_ivas_spar_dec_open                /* VA: issue 1386: fix use-of-uninitialized value in ivas_spar_dec_open() */



/* #################### End BE switches ################################## */

lib_dec/ivas_init_dec.c

+3 −0
Original line number Diff line number Diff line
@@ -1154,6 +1154,9 @@ ivas_error ivas_init_decoder_front( 
    st_ivas->ism_mode = ISM_MODE_NONE;

    st_ivas->mc_mode = MC_MODE_NONE;



#ifdef FIX_1384_MSAN_ivas_spar_dec_open

    st_ivas->sid_format = SID_FORMAT_NONE;

#endif

    st_ivas->sba_dirac_stereo_flag = 0;



    /* HRTF binauralization latency in ns */