address/remove a few VE2AT comments (fceb96f4) · Commits · IVAS Codec Public Collaboration / IVAS Codec

lib_dec/ivas_ls_custom_dec.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -29,7 +29,6 @@
		the United Nations Convention on Contracts on the International Sales of Goods.

		*******************************************************************************************************/
		// VE2AT: this file functions are called from lib_dec only; is it expected, or it will be implemented for Ext renderer later?
		#include <stdint.h>
		#include "options.h"
		#include "ivas_prot.h"

+1 −0

Original line number	Diff line number	Diff line
		@@ -1033,6 +1033,7 @@ typedef struct ivas_lfe_dec_data_structure


		// VE2AT: the following structures are used only in lib_dec; is it expected?
		// AT2VE: at the moment yes, I anticipate we will need to move them out in the future.
		/----------------------------------------------------------------------------------
		* VBAP structures
		----------------------------------------------------------------------------------/

+1 −1

Original line number	Diff line number	Diff line
		@@ -100,7 +100,7 @@ static ivas_error ivas_td_decorr_init( ivas_td_decorr_state_t *hTdDecorr, const
		*
		* Allocate and initialize SPAR time domain decorrelator handle
		------------------------------------------------------------------------/
		// VE2AT: this function is used also in lib_rend...; where to put it?
		// VE2AT: this function is used also in lib_rend...; where to put it? --> TODO move
		ivas_error ivas_spar_td_decorr_dec_open(
		ivas_td_decorr_state_t *hTdDecorr, / i/o: SPAR Covar. decoder handle */
		const int32_t output_Fs, /* i : output sampling rate */

+1 −1

Original line number	Diff line number	Diff line
		@@ -41,7 +41,7 @@
		#else
		#include "lib_rend.h"
		#endif
		#include "ivas_stat_dec.h" // VE2AT: needed for Decoder_Struct; what to do with this? Is this related to #156?
		#include "ivas_stat_dec.h" // VE2AT: needed for Decoder_Struct; what to do with this? Is this related to #156? AT2VE: Yes, need to keep until #156 is resolved.

		/* clang-format off */

+2 −10

Original line number	Diff line number	Diff line
		@@ -38,7 +38,7 @@
		#include "cnst.h"
		#include "ivas_cnst.h"
		#include "ivas_stat_com.h"
		#include "common_api_types.h" // VE2AT: should it stay here? (in lib_enc, lib_dec, there is no such include)
		#include "common_api_types.h"
		#endif


		@@ -49,15 +49,7 @@ typedef struct
		{
		float azimuth;
		float elevation;
		} IVAS_REND_AudioObjectPosition; // VE2AT: where should this go, into common_api_types.h, ...? Or should there be introduced public -> internal conversion?


		// VE2AT: not used, can it be removed?
		// typedef struct
		//{
		// int16_t numLfeChannels;
		// float lfeOutputGains[IVAS_MAX_INPUT_LFE_CHANNELS][IVAS_MAX_OUTPUT_CHANNELS];
		//} IVAS_REND_LfeRouting;
		} IVAS_REND_AudioObjectPosition; // VE2AT: where should this go, into common_api_types.h, ...? Or should there be introduced public -> internal conversion? AT2VE: will be moved back in !421

		typedef struct
		{