Skip to content

Uninitialized value in ivas_masa_combine_directions with OMASA input

Basic info

  • Commit SHA: main
  • Platform: all

Bug description

Noticed in MR !2477 that with OMASA path, the importance value in if-check alerted MSAN for use-of-uninitialized-value. This was pinpointed to importanceWeight value specifically when coming from OMASA side. This is a correct warning but has no significant signal effect as the importance is not really used at this point of the code. The correct solution is to skip relevant parts of the combination code. This probably should also apply to BASOP.

Ways to reproduce

For example with this command using MSAN build

./IVAS_cod -ism_masa 4 1 ../scripts/testv/stv20sOMASA_4ISM1TC_ISM1.csv ../scripts/testv/stv20sOMASA_4ISM1TC_ISM2.csv ../scripts/testv/stv20sOMASA_4ISM1TC_ISM3.csv ../scripts/testv/stv20sOMASA_4ISM1TC_ISM4.csv ../scripts/testv/stv20sOMASA_4ISM1TC.met 24400 48 ../scripts/testv/stv20sOMASA_4ISM1TC.wav debug.bit