Skip to content

Review TCX LPC Bitstream Writer

This is a follow-up from #451 (closed): There is strange code in stereo_tcx_core_enc() wrt the LPC bitstream writer:

    /*--------------------------------------------------------------------------------*
     * Write LPC parameters
     *--------------------------------------------------------------------------------*/

    n = st->coder_type; /* IVAS_fmToDo: hack to keep bit-exactness -> TBV */
    st->coder_type = INACTIVE;
    writeLPCparam( st, hBstr, param_lpc, bits_param_lpc, no_param_lpc, &total_nbbits );
    st->coder_type = n;

I don't think the storage, modification and re-assignment st->coder_type is actually needed. Would like to treat this separately, not in a monster MR...