Skip to content

Revision of ToDo comments

Below is a list of ToDos in the framework. Please try to address them as much as possible before the call scheduled on May 31.

If a ToDo is just a leftover or it has no follow-up, I suggest to remove them directly in MR !627 (merged). If changes in the source code are needed, please create a separate ticket with a separate compilation flag to address them.

List of ToDos (from May 10, 2023):

  • ..\lib_dec\acelp_core_dec.c(1093): if ( st->hPFstat != NULL && st->last_bwidth >= WB && ( st->core_brate > ACELP_24k40 || st->element_mode > EVS_MONO ) && st->core_brate <= ACELP_32k ) /* TODO: TBV for TD stereo */ -> Tommy (VA)
  • ..\lib_dec\core_switching_dec.c(377): st->last_coder_type = GENERIC; /* TODO - fcs : this might be superfluous */ -> Eleni
  • ..\lib_dec\dec_tcx.c(1510): if ( st->element_mode == EVS_MONO || L_spec < L_frameTCX ) /* todo: this is temporary to maintain EVS BE, this is a bug and should be fixed also for EVS (see issue 13) */ -> this is a CR fix to be brought to the EVS, create a ticket (Eleni)
  • ..\lib_dec\dec_tcx.c(1745): st->old_fpitchFB = st->old_fpitch * (float) L_frameTCX_glob / (float) L_frame_glob; /* TODO - or maybe used min(L_frame_TCX,L_FRAME48k) ... */ -> Eleni
  • (KEEP) ..\lib_dec\swb_bwe_dec.c(270): /* IVAS_fmToDo: wtda() does not support L_FRAME length; thus temporarily resample the signal */ -> Huan-yu, create a new ticket (Vaclav)
  • (KEEP)..\lib_dec\swb_bwe_dec.c(271): /* IVAS_fmToDo: delay output[] by 1.25ms ? */ -> Huan-yu
  • (KEEP)..\lib_dec\swb_bwe_dec.c(589): /* todo - wtda() does not support L_FRAME length; thus temporarily resample the signal */ -> Huan-yu
  • (KEEP)..\lib_dec\swb_bwe_dec.c(590): /* todo - delay output[] by 1.25ms ? */ -> Huan-yu
  • (KEEP)..\lib_dec\swb_bwe_dec.c(737): /* IVAS_fmToDo: synth[] is @internal_Fs!!! */ -> Huan-yu
  • ..\lib_dec\swb_tbe_dec.c(1866): /* !!! TODO: read empty bits - should be removed */ -> @malenovsky
  • ..\lib_dec\updt_dec.c(553): for ( i = 0; i < NB_SUBFR; i++ ) /* ToDo: why it supposes 12.8 kHz only and not 16kHz core? */ - parameter st->prev_tilt_code_dec -> @malenovsky
  • (KEEP) ..\lib_dec\jbm_jb4_circularbuffer.c(449): memmove( elements + i + 1, elements + i, ( size - i ) * sizeof( JB4_CIRCULARBUFFER_ELEMENT ) ); / IVAS_fmToDo: avoid use of memmove() */ -> Kacper
  • (KEEP)..\lib_dec\jbm_jb4_inputbuffer.c(237): memmove( h->data + insertPos + 1, h->data + insertPos, ( h->writePos - insertPos ) * sizeof( JB4_INPUTBUFFER_ELEMENT ) ); /* IVAS_fmToDo: avoid use of memmove() */ -> Kacper
  • (KEEP)..\lib_dec\jbm_jb4_inputbuffer.c(248): memmove( h->data + h->readPos - 1, h->data + h->readPos, low * sizeof( JB4_INPUTBUFFER_ELEMENT ) ); /* IVAS_fmToDo: avoid use of memmove() */ -> Kacper
  • ..\lib_dec\jbm_pcmdsp_apa.c(466): int16_t frm_in[APA_BUF]; /* TODO(mcjbm): this buffer could be smaller - always allocates space for 16 channels */ -> Kacper
  • ..\lib_dec\ivas_stat_dec.h(801): /TODO : reuse hFbMixer->prior_mixer for this as that buffer is unused in decoder with FB_HARMONIZATION/
  • ..\lib_dec\ivas_stat_dec.h(1184): int16_t BER_detect; /* BER detect flag / / IVAS_fmToDo: eventually replace hCoreCoder->BER_detect by a pointer to ease the updating of this main parameter */ -> needs more discussion, remove the comment (Vaclav)
  • ..\lib_dec\ivas_binRenderer_internal.c(150): hBinRenderer->nInChannels = ( audioCfg2channels( input_config ) - isLoudspeaker ); // TODO maybe an audioCfg2channels_woLFE() function? Works as long as only 1 LFE is present -> Archit
  • ..\lib_dec\ivas_binRenderer_internal.c(449): // ToDo: hBinRenderer->ivas_format is never set to ISM_FORMAT -> function ivas_binRenderer()->ivas_binaural_obtain_DMX() -> Archit
  • ..\lib_dec\ivas_cpe_dec.c(295): /* subtract metadata bitbudget / / IVAS_fmToDo: TBC whether it is not better to distribute the metadata bits equally between 2 channels */ -> sts[0]->bits_frame_channel -= nb_bits_metadata; -> check for TD stereo, Tommy : It's better that way, and we don,t want to change this at this stage any way, comment removed from the code
  • ..\lib_dec\ivas_cpe_dec.c(830): /* make sure we deallocate a potential distinct hTcxCfg for a MCT LFE channel (can only happen in rs) */ /TODO Check this again with LFE clean up!/ -> Eleni see !692 (merged)
  • ..\lib_dec\ivas_dec.c(61): float output[MAX_OUTPUT_CHANNELS][L_FRAME48k]; /* 'float' buffer for output synthesis, MAX_OUTPUT_CHANNELS channels / / IVAS_fmToDo: buffer can be allocated dynamically based on the actual number of output channels */ -> see #340, remove the comment (Vaclav)
  • ..\lib_dec\ivas_dec.c(387): float gain = 0.8414f; /* Todo: Temporary gain for roughly matching the loudness. To be tuned later together with other outputs. */
  • (KEEP) ..\lib_dec\ivas_dirac_dec.c(2266): /* Todo: This access to azimuth & elevation may use wrong indices as access should probably be based on hDirAC->dirac_read_idx */
    • Touched by JBM
  • ..\lib_dec\ivas_init_dec.c(462): // TODO: needs more work for HOA
  • ..\lib_dec\ivas_ism_dtx_dec.c(121): /* IVAS_fmToDo: more work needed when the number of transported objects is not constant */ -> create an issue (Vaclav)
  • ..\lib_dec\ivas_ism_metadata_dec.c(219): /* IVAS_fmToDo: more work needed when the number of transported objects is not constant */ -> create an issue (Vaclav)
  • ..\lib_dec\ivas_ism_renderer.c(158): // TODO tmu review when #215 is resolved
  • ..\lib_dec\ivas_mct_dec.c(104): /* IVAS_fmToDo: more work needed for switching the number of transport channels */ -> related to #215, still found relevant to review, up to proponents of relevant technologies
  • ..\lib_dec\ivas_pca_dec.c(235): /* @@@TODO: check how ivas_total_brate is set if bfi == 1 */ // ToDo: and what happens in DTX where "ivas_total_brate" can be close to zero? -> Stephane
  • ..\lib_dec\ivas_pca_dec.c(243): // todo - rather call PCA resets in the first PCA frame -> remove (Vaclav)
  • ..\lib_dec\ivas_post_proc.c(149): /* IVAS_fmToDo: harmonize buffers hCPE->output_mem and hTcxDec->FBTCXdelayBuf ?? */ -> remove (Vaclav)
  • (KEEP) ..\lib_dec\ivas_qmetadata_dec.c(1136): /* TODO: still use old sid frame size to keep bitexactness */
  • (KEEP) ..\lib_dec\ivas_qmetadata_dec.c(1142): /* TODO: still use old sid frame size to keep bitexactness */
  • (KEEP) ..\lib_dec\ivas_qmetadata_dec.c(1148): /* TODO: still use old sid frame size to keep bitexactness */
  • (KEEP) ..\lib_dec\ivas_qmetadata_dec.c(1155): if ( ivas_format == MASA_FORMAT && nchan_transport == 2 ) /* corresponding to SID_MASA case; Todo: needs to be checked for SBA */
  • (KEEP) ..\lib_dec\ivas_qmetadata_dec.c(1268): /* TODO: temporary hack to keep BE */
  • ..\lib_dec\ivas_sba_dec.c(65): /* st_ivas->hSCE[0]->hCoreCoder[0]->cna_dirac_flag = 0; / / Todo: Check if these can be enabled */
  • ..\lib_dec\ivas_sba_dec.c(77): st_ivas->hCPE[0]->hCoreCoder[n]->cna_dirac_flag = 0; /* Todo: Check if these can be enabled */
  • ..\lib_dec\ivas_sba_rendering_internal.c(309): // TODO tmu review when #215 is resolved -> Archit
  • ..\lib_dec\ivas_spar_md_dec.c(46):/*#define ENABLE_DITHER / / IVAS_fmToDo: development switch */
  • ..\lib_dec\ivas_spar_md_dec.c(587): case 9: /* IVAS_HOA_2_CH */ // ToDo: is this relevant?
  • (KEEP) ..\lib_dec\ivas_spar_md_dec.c(590): case 16: /* IVAS_HOA_3_CH */ // ToDo: is this relevant?
  • ..\lib_dec\ivas_stereo_cng_dec.c(96): /* TODO: still use old number of bits to keep bitexactness in output */
  • ..\lib_dec\ivas_stereo_dft_dec.c(2426): /* IVAS_fmToDo: the assert has to be changed with proper bitstream error handling */ -> keep it
  • ..\lib_dec\ivas_stereo_ica_dec.c(151): /* IVAS_fmToDo: QCTodo: Need to address [16, 32] kHz @ Encoder --> 48 kHz Decoder. 48kHz-->48kHz is ok */ -> Tommy
  • ..\lib_dec\ivas_stereo_icbwe_dec.c(742): /* QC: TODO - TBV */ -> Tommy
  • ..\lib_dec\ivas_stereo_switching_dec.c(1548): /* Todo: apply panning to buffers instead of simply using dmx in left and right channel */ -> Eleni
  • ..\lib_dec\ivas_tcx_core_dec.c(48):/defne FIX_IVAS_337/ // TODO: needs more work -> @multrus
  • ..\lib_dec\ivas_vbap.c(185): /* TODO: are these two paths correct behaviour or should and error be returned ? */
  • ..\lib_dec\lib_dec.c(615): if ( !bfi ) /* TODO(mcjbm): Is this ok for bfi == 2 (partial frame)? Is there enough info to fully configure decoder? */ -> Kacper
  • ..\lib_dec\lib_dec.c(1470): /* TODO(mcjbm): ringbuffer capacity should be configurable by user */
  • ..\lib_dec\lib_dec.c(1521): set_s( hVoIP->apaExecBuffer, 0, hVoIP->nSamplesFrame ); /* TODO(mcjbm): Could be optimized: just write directly to output buffer */
  • ..\lib_enc\core_switching_enc.c(261): set_f( st->hBWE_FD->old_syn_12k8_16k, 0, NS2SA( 16000, DELAY_FD_BWE_ENC_NS ) ); /* TODO - TBV: this might not be needed */ -> Huan-yu
  • ..\lib_enc\fd_cng_enc.c(1255): for ( p = 0; p < NPART; p++ ) /* TODO Note: NPART should likely be N[ch] if N[ch] may change */ -> Jan
  • ..\lib_enc\fd_cng_enc.c(1263): convertToMS( NPART, ms_ptr[0], ms_ptr[1], 0.5f ); /* TODO Note: NPART should likely be N[0] if N[0] may change */ -> Jan
  • ..\lib_enc\fd_cng_enc.c(1265): E[0] = sum_f( ms_ptr[0], NPART ); /* TODO Note: NPART should likely be N[0] if N[0] may change */ -> Jan
  • ..\lib_enc\fd_cng_enc.c(1301): gain[0] = sum_f( ms_ptr[0], NPART ); /* TODO Note: NPART should likely be N[0] if N[0] may change */ -> Jan
  • ..\lib_enc\fd_cng_enc.c(1313): convertToMS( NPART, ms_ptr[0], ms_ptr[1], 1.0f ); /* TODO Note: NPART should likely be N[0] if N[0] may change */ -> Jan
  • ..\lib_enc\fd_cng_enc.c(1321): for ( p = 0; p < NPART; p++ ) /* TODO Note: NPART should likely be N[0] if N[0] may change */ -> Jan
  • ..\lib_enc\init_enc.c(695): // ToDo: reduction possible for MCT_CHAN_MODE_LFE channel - see I1-172
  • ..\lib_enc\swb_tbe_enc.c(2153): /* Todo: input properly the number of bits */ -> Lasse
  • ..\lib_enc\evs_enc.c(267): /* ToDo: this is a hack to keep bitexactness wrt. EVS but the logic is wrong */ -> related to FIX_I4_OL_PITCH (EVS bug), remove the comment (Vaclav)
  • ..\lib_enc\voiced_enc.c(501): /* TODO: deallocation missing */ -> probably a leftover, @malenovsky to check
  • ..\lib_enc\ivas_agc_enc.c(458): /* TODO: return error once error codes are harmonized */
  • ..\lib_enc\ivas_agc_enc.c(480): /* TODO: return error once error codes are harmonized */
  • ..\lib_enc\ivas_corecoder_enc_reconfig.c(324): mvr2r( input_buff[n], st_ivas->hCPE[cpe_id]->hCoreCoder[0]->input_buff, len_inp_memory ); /* TODO VoiceAge: Please check if this should be hCoreCoder[n] */
  • (KEEP) ..\lib_enc\ivas_dirac_enc.c(237): /* :TODO: if the number of parameter bands change, do a meaningful mapping of parameter buffers from old to new band setting */
  • ..\lib_enc\ivas_dirac_enc.c(385): /* ToDo: If DIRAC_MIN_BITRATE_4_TRANS_CHAN is reached with DTX on (possible only with bitrate switching)
  • ..\lib_enc\ivas_enc.c(65): float data_f[MAX_INPUT_CHANNELS][L_FRAME48k]; /* IVAS_fmToDo: buffer can be allocated dynamically based on the number of analysed channels */ -> see #340, remove the comment (Vaclav)
  • ..\lib_enc\ivas_enc.c(139): else if ( !( ivas_format == MC_FORMAT && i == LFE_CHANNEL ) ) /*TODO: is the HPF needed for LFE channel? */ -> Nokia to take care; comment to be removed
  • ..\lib_enc\ivas_front_vad.c(179): /* TODO: this may need adaption if ever using this for MDCT-Stereo (see conditional inside of analy_sp) */ -> Jan
  • ..\lib_enc\ivas_front_vad.c(213): /* TODO: if using this for MDCT-Stereo, this may need to be done on both channels? or maybe some more logic is needed */ -> Jan
  • ..\lib_enc\ivas_front_vad.c(214): /* TODO: do we really need this for VAD only ? */ -> Jan
  • ..\lib_enc\ivas_lfe_enc.c(300): /* reset all indices that were already written - TODO: maybe better store them temporarily first and write at the very end? */
  • ..\lib_enc\ivas_masa_enc.c(2026): /* TODO: a nicer negation */
  • ..\lib_enc\ivas_mcmasa_enc.c(1239): float dmx[][L_FRAME48k + NS2SA( 48000, IVAS_FB_ENC_DELAY_NS )], /* i/o: downmix signal to be transformed into another format. TODO: buffer size into define? */
  • (KEEP) ..\lib_enc\ivas_qmetadata_enc.c(995): /* TODO: still use old sid frame size to keep bitexactness */
  • (KEEP) ..\lib_enc\ivas_qmetadata_enc.c(1001): /* TODO: still use old sid frame size to keep bitexactness */
  • (KEEP) ..\lib_enc\ivas_qmetadata_enc.c(1007): /* TODO: still use old sid frame size to keep bitexactness */
  • (KEEP) ..\lib_enc\ivas_qmetadata_enc.c(1187): /* TODO: temporary to keep BE */
  • ..\lib_enc\ivas_spar_encoder.c(319): // ToDo: can hFbMixer->ppFilterbank_prior_input be replaced by st->input ?
  • ..\lib_enc\ivas_spar_encoder.c(910): /* IVAS_fmToDo: This AGC on/off bit should be removed when the command line option to force enable/disable AGC is
  • ..\lib_enc\ivas_spar_md_enc.c(563): Indice ind_list_tmp[MAX_BITS_METADATA]; // IVAS_fmToDo: size to be optimized
  • (KEEP) ..\lib_enc\ivas_spar_md_enc.c(1717): /* TODO: Bitrate switching will require dependence on bands_bw, and changes to time differential coding/prior index
  • ..\lib_enc\ivas_stereo_cng_enc.c(179): /* TODO: still use old number of bits to keep bitexactness in output */
  • ..\lib_enc\ivas_stereo_icbwe_enc.c(420): /* IVAS-219: QCToDo: ICBWEDFT for WB TBV */ -> @vaillancour and @malenovsky
  • ..\lib_enc\ivas_stereo_icbwe_enc.c(508): /* IVAS-219: QCToDo: check this "if condition" if IVAS_CPE_TD is needed? */ -> @vaillancour and @malenovsky
  • ..\lib_enc\ivas_stereo_icbwe_enc.c(520): if ( ( hStereoICBWE->prev_refChanIndx_bwe != hStereoICBWE->refChanIndx_bwe ) || ( st->last_extl != st->extl ) || st->flag_ACELP16k != 1 ) /* IVAS-219: QCToDo: dont reset for SWB<->FB */ -> @vaillancour and @malenovsky
  • ..\lib_enc\ivas_tcx_core_enc.c(395): n = st->coder_type; /* IVAS_fmToDo: hack to keep bit-exactness -> TBV */ -> @multrus -> see #530 (closed)
  • ..\lib_enc\lib_enc.c(882): ( ( hEncoderConfig->ivas_format == MASA_FORMAT && hEncoderConfig->ivas_total_brate > IVAS_128k ) || // ToDo: remove the bitrate limitation
  • ..\lib_enc\lib_enc.c(1174):/* IVAS_fmToDo: Currently unused and untested */ -> remove comment (Vaclav)
  • ..\lib_enc\lib_enc.c(1910):#if 0 // IVAS_fmToDo: temporary disabled to keep EVS bit-exactness -> to be verified -> ticket #74, @multrus
  • ..\lib_com\bitstream.c(2016): if ( bfi == FRAMEMODE_MISSING ) /* TODO(mcjbm): This fixes channel-aware mode BE. Still requires review from a bitstream reading expert */
  • ..\lib_com\bitstream.c(2182): bfi != FRAMEMODE_FUTURE && /* TODO(mcjbm): This fixes channel-aware mode BE. Still requires review from a bitstream reading expert */
  • ..\lib_com\bitstream.c(2226): if ( st_ivas->bfi == 0 || st_ivas->bfi == FRAMEMODE_FUTURE /* TODO(mcjbm): This fixes channel-aware mode BE. Still requires review from a bitstream reading expert */
  • ..\lib_com\bitstream.c(2841): /* TODO: temporary hack, need to decide what to do with core-coder bitrate */ -> function FdCngDecodeMDCTStereoSID()->dtx_read_padding_bits() -> Jan
  • ..\lib_com\core_com_config.c(745): /* TODO: is this always the case ? */ -> @multrus
  • ..\lib_com\gs_bitallocation.c(619): if ( L_frame == L_FRAME16k && core_brate > ACELP_32k ) /* TODO - TBV if applicable */ -> Tommy
  • (KEEP) ..\lib_com\ivas_cnst.h(113): AUDIO_CONFIG_MASA1, /* MASA1 */ // TODO: seems not to be used -> will be needed in the future, remove the comment (Vaclav)
    • Keep (both TODO and enum value) until EXT renderer is finished.
  • (KEEP) ..\lib_com\ivas_cnst.h(114): AUDIO_CONFIG_MASA2, /* MASA2 */ // TODO: seems not to be used
    • Keep (both TODO and enum value) until EXT renderer is finished.
  • ..\lib_com\ivas_cnst.h(182):#define MAX_BITS_METADATA 2640 /* max. bit-budget of metadata, one channel / / IVAS_fmToDo: to be confirmed for final value once mature */ -> @vaclav
  • ..\lib_com\ivas_cnst.h(386): TAG_ISM_LOOP_END = TAG_ISM_LOOP_START + 100, /* IVAS_fmToDo: to be reviewed once the final metadata are defined */ -> @vaclav
  • ..\lib_com\ivas_cnst.h(1027):/* TD decorr */ // ToDo: not all 16CH are currently supported -> to be revisited later -> Dolby
  • ..\lib_com\stl.h(60):#include "options.h" /* TODO: TEMPORARY during BASOP development - to be removed */ -> BASOP_NOGLOB to be kept, rewrite the comment (@vaclav)
  • ..\lib_com\ivas_pca_tools.c(648): norm_q = inv_sqrt( norm_q ); // TODO: possible division by 0
  • ..\lib_com\ivas_stereo_ica_com.c(80): /* IVAS-220: QCToDo: (check N for dependency on the inputFs) */ -> @malenovsky
  • ..\lib_rend\ivas_crend.c(739): /* TODO tmu : Based on ivas_crend_open() - could be harmonized / refactored */ -> remove (Archit)
  • ..\lib_rend\ivas_objectRenderer_hrFilt.c(92): Src_p->InputFrame_p += subframe_length; /* Increment input pointer -- todo: should we remove this and input the current subframe instead? */ -> remove @norvell
  • ..\lib_rend\ivas_reverb.c(397): /* TODO: values below could be reconsidered, and/or be made variable */ -> remove (Marek)
  • ..\lib_rend\ivas_reverb.c(543): // TODO: Compute proper (group) Delay from IIR filter -> remove (Marek)
  • ..\lib_rend\ivas_stat_rend.h(600): float hrf_left_prev[SFX_SPAT_BIN_MAX_FILTER_LENGTH]; /* Todo: Should we allocate these buffers with malloc() instead of the maximum length? */ -> @norvell
  • ..\lib_rend\lib_rend.c(93): /* TODO @Philips : would this be a better place to store the render config data? -> remove (Marek)
  • ..\lib_rend\lib_rend.c(96): * feel free to remove this TODO. -> Marek
  • ..\lib_rend\lib_rend.c(184): /* TODO @Philips - inputConfig should not be stored here, but read from e.g. input_mc->input_base.inConfig, please remove this */ -> Marek
  • ..\lib_rend\lib_rend.c(1801): /* TODO tmu : needs review allocate both renderers; needed if headrotation is toggled so the renderer can be switched */ -> create issue (Archit)
  • (KEEP) ..\lib_rend\lib_rend.c(2198): decDummy->hDecoderConfig->ivas_total_brate = IVAS_512k; /* Todo Nokia: This is preventing initialization of 2TC as 1TC, should be fixed properly in ivas_dirac_dec_config() */
    • Keep until DirAC renderer refactoring is done
  • (KEEP) ..\lib_rend\lib_rend.c(2199): decDummy->sba_mode = SBA_MODE_NONE; /* Todo Nokia: This is done to prevent ivas_dirac_dec_config() to not use uninitialized value. It could be considered if this should not be even accessed when not in SBA. */
    • Keep until DirAC renderer refactoring is done
  • (KEEP) ..\lib_rend\lib_rend.c(2200): decDummy->mc_mode = MC_MODE_NONE; /* Todo Nokia: This should be also refactored in such way that it is not checked if not in MC mode */
    • Keep until DirAC renderer refactoring is done
  • (KEEP) ..\lib_rend\lib_rend.c(2214): /* Todo refactor: Access to qmetadata is not required by the algorithm. */
    • Keep until DirAC renderer refactoring is done
  • (KEEP) ..\lib_rend\lib_rend.c(2281): decDummy->hDecoderConfig->ivas_total_brate = IVAS_512k; /* Todo Nokia: This is preventing initialization of 2TC as 1TC, should be fixed properly in ivas_dirac_dec_config() */
    • Keep until DirAC renderer refactoring is done
  • (KEEP) ..\lib_rend\lib_rend.c(2282): decDummy->sba_mode = SBA_MODE_NONE; /* Todo Nokia: This is done to prevent ivas_dirac_dec_config() to not use uninitialized value. It could be considered if this should not be even accessed when not in SBA. */
    • Keep until DirAC renderer refactoring is done
  • (KEEP) ..\lib_rend\lib_rend.c(2283): decDummy->mc_mode = MC_MODE_NONE; /* Todo Nokia: This should be also refactored in such way that it is not checked if not in MC mode */
    • Keep until DirAC renderer refactoring is done
  • (KEEP) ..\lib_rend\lib_rend.c(2291): /* Todo refactor: Access to qmetadata is not required by the algorithm. */
    • Keep until DirAC renderer refactoring is done
  • (KEEP) ..\lib_rend\lib_rend.c(2351): decDummy->hDecoderConfig->ivas_total_brate = IVAS_512k; /* Todo Nokia: This is preventing initialization of 2TC as 1TC, should be fixed properly in ivas_dirac_dec_config() */
    • Keep until DirAC renderer refactoring is done
  • (KEEP) ..\lib_rend\lib_rend.c(2352): decDummy->sba_mode = SBA_MODE_NONE; /* Todo Nokia: This is done to prevent ivas_dirac_dec_config() to not use uninitialized value. It could be considered if this should not be even accessed when not in SBA. */
    • Keep until DirAC renderer refactoring is done
  • (KEEP) ..\lib_rend\lib_rend.c(2353): decDummy->mc_mode = MC_MODE_NONE; /* Todo Nokia: This should be also refactored in such way that it is not checked if not in MC mode */
    • Keep until DirAC renderer refactoring is done
  • (KEEP) ..\lib_rend\lib_rend.c(2506): RENDER_CONFIG_DATA hRendCfg ) / Todo: This is not used at all within MASA. Support might be better to do after refactoring. */
    • Keep until DirAC renderer refactoring is done
  • ..\lib_rend\lib_rend.c(3439): /* TODO tmu : this function only returns the maximum delay across all inputs -> create issue (Archit)
  • ..\lib_rend\lib_rend.c(4053): /* TODO(sgi): This is calculated for each output channel - can be optimised */ -> create issue (Kacper)
  • ..\lib_rend\lib_rend.c(4316): /* TODO tmu : missing: interpolation between positions, 5ms rendering */ -> Archit to check
  • ..\lib_rend\lib_rend.c(4363): /* TODO tmu : missing: interpolation between positions, 5ms rendering */ -> Archit to check
  • ..\lib_rend\lib_rend.c(4396): /* TODO tmu : missing: interpolation between positions, 5ms rendering */ -> Archit to check
  • ..\lib_rend\lib_rend.c(4397): /* TODO(sgi): Possible optimization: less processing needed if position didn't change */ -> Kacper
  • ..\lib_rend\lib_rend.c(4398): /* TODO tmu2sgi: needs a lot of cleanup, we could also add rot_gains_prev to ismInput and use that */ -> Archit
  • ..\lib_rend\lib_rend.c(4477): /* TODO(sgi): Possible optimization: less processing needed if position didn't change */ -> Archit
  • ..\lib_rend\lib_rend.c(4494): // TODO tmu review when #215 is resolved -> Archit
  • ..\lib_rend\lib_rend.c(4503): // TODO tmu review when #215 is resolved -> Archit
  • ..\lib_rend\lib_rend.c(4546): // TODO tmu review when #215 is resolved -> Archit
  • ..\lib_rend\lib_rend.c(4559): // TODO tmu review when #215 is resolved -> Archit
  • ..\lib_rend\lib_rend.c(4761): /* TODO tmu : needs delay compensation */ -> issue exists, remove comment (Archit)
  • ..\lib_rend\lib_rend.c(4831): /* TODO tmu : needs delay compensation */ -> issue exists, remove comment (Archit)
  • ..\lib_rend\lib_rend.c(4903): /* TODO tmu : needs delay compensation */ -> issue exists, remove comment (Archit)
  • ..\lib_rend\lib_rend.c(5340): /* TODO(sgi): Remove code duplication w.r.t. MASA rendering to other output configs */ -> remove (Kacper)
  • ..\lib_rend\lib_rend.c(5428): /* ToDo */ -> related to renderMasaToBinauralRoom() -> Tapani
  • ..\lib_rend\lib_rend.h(79):/* TODO(sgi): Harmonize with AUDIO_CONFIG */ -> create issue; Kacper
  • ..\lib_rend\lib_rend.h(146):/* ToDo: Support for custom HRTFs will be added in the future. */ -> issue #314 (closed), remove comment (Archit)
  • ..\lib_rend\lib_rend.h(150): void* TODO -> issue #314 (closed), remove comment (Archit)
  • ..\lib_util\cmdln_parser.c(75): /* TODO(sgi): Don't print out usage after this - props.match is used there */ -> Kacper
  • ..\lib_util\cmdln_parser.c(340): /* TODO(sgi): make matchShort optional */ -> Kacper
  • ..\lib_util\tinywavein_c.h(183): /* todo: merge "bext" reading into this loop */ -> @multrus
  • ..\apps\encoder.c(1479): else if ( strcmp( argv_to_upper, "-BYPASS" ) == 0 ) // TODO: should be renamed to "-pca" -> will be removed at the end -> Stephane
  • ..\apps\renderer.c(210): .description = "Input sampling rate in kHz (16, 32, 48) - required only with raw PCM inputs", /* TODO(sgi): Add sampling rate to scene description files */ -> Kacper
  • ..\apps\renderer.c(240): .description = "Panning mono no diegetic sound to stereo -1<= pan <= 1\nleft or l or 1->left, right or r or -1->right, center or c or 0 ->middle\n(todo: implementation)", -> Marc to update print-out, remove the comment
  • ..\apps\renderer.c(730): /* TODO tmu: how should we handle this on CLI for multiple MC inputs? */
  • ..\apps\renderer.c(752): /* TODO(sgi): Command line only supports one custom LS input for now, extend */
  • (KEEP) ..\apps\renderer.c(1474): /return IVAS_REND_AUDIO_CONFIG_MASA1;/ // ToDo: temporarily disabled to avoid compilation warnings
    • Keep until DirAC renderer refactoring is done
  • ..\lib_dec\ivas_dirac_decorr_dec.c(159): freq_domain_decorr_ap_params->use_ducker = 1; /* ToDo: fcs: fixed for now but can be adaptive in an extended version */ -> Stefan B.
  • ..\lib_dec\ivas_qmetadata_dec.c(2391): assert( ( alphabet_size >= 1 ) ); /* ToDo: fcs: to check if this additional conditon is really needed: && (alphabet_size <= (1U << 31) - 1));*/ -> @multrus
  • ..\lib_enc\ivas_qmetadata_enc.c(2287): assert( ( alphabet_size >= 1 ) ); /* ToDo: fcs: to check if this additional conditon is really needed: && (alphabet_size <= (1U << 31) - 1));*/ -> @multrus
  • ..\lib_enc\ivas_qmetadata_enc.c(2526): assert( ( alphabet_size >= 1 ) ); /* ToDo: fcs: to check if this additional conditon is really needed: && (alphabet_size <= (1U << 31) - 1));*/ -> @multrus
  • ..\lib_com\rom_com.c(15689): getK(TBD,TBD)+ maxqKInd=TBD --> KMAX=1024, needs support , 32bit saturates at dim~=4 -> @norvell
  • ..\lib_com\rom_com.c(15690): getK(TBD,TBD)+ maxqKInd=TBD --> KMAX=32767, needs support, 32bit saturates at dim =3 -> @norvell
  • ..\lib_util\tinywaveout_c.h(208): /* ToDo: tbd: wavfmt ext hdr here */ -> @multrus
Edited by malenovsky