Resolve #890 "Mismatch of the expected and provided function argument size in renderIsmToMASA"
- Related issues: #890 (closed), #887 (closed)
- Requested reviewers:
Reason why this change is needed
In lib_rend/lib_rend.c
function renderIsmToMasa
the variable
float tmpRendBuffer[MAX_NUM_OBJECTS][L_FRAME48k];
is used as the input argument to
-
copyBufferTo2dArray
expecting the argument to befloat array[MAX_OUTPUT_CHANNELS][L_FRAME48k]
, and -
accumulate2dArrayToBuffer
expecting the argument to befloat array[MAX_OUTPUT_CHANNELS][L_FRAME48k]
.
In both cases, the actual number of channels to process is read from buffer->config.numChannels
and no over-indexing takes place.
Description of the change
Change the function interface definitions to use undefined first dimension size for the 2D inputs:
-
copyBufferTo2dArray
to usefloat array[][L_FRAME48k]
-
accumulate2dArrayToBuffer
to usefloat array[][L_FRAME48k]
Affected operating points
- Potentially all external renderer rendering operations
- Since the change is only in the definition of the function interface, everything should be BE.
Related to #890 (closed)
Edited by Jouni Paulus