Skip to content

Resolve "Mismatch of the expected and provided function argument size in MasaFileWriter_open"

Jouni Paulusrequested to merge
889-mismatch-of-the-expected-and-provided-function-argument-size-in-masafilewriter_open into main

Reason why this change is needed

The function MasaFileWrite_open determines the output filename with the call

char filePath[FILENAME_MAX - 12];
getExtMasaMetadataFileName( outputWavFilename, &filePath );

while the function is defined as

static void getExtMasaMetadataFileName(
    const char *outputWavFilename,                                  /* i  : name of the output audio file         */
    char metadata_filename[IVAS_MAX_NUM_OBJECTS][FILENAME_MAX - 12] /* o  : name of the output masa metadata file */
)

Internally, the function uses metadata_filename[0], so no over-indexing takes place.

Description of the change

Change the interface of getExtMasaMetadataFileName to accept only a single output filename and to include the length of the output array. The implementation of the function is aligned with the changed interface.

Affected operating points

This affects the determination of the output filename when outputting a MASA file. The change is expected to be purely transparent refactoring leading to BE bitstreams and outputs.

Merge request reports