Skip to content

[non-BE] Resolve #897: "USAN null pointer in MASA external renderer to Ambisonics"

Jouni Paulus requested to merge 897-usan-null-pointer-in-masa-external-renderer-to-ambisonics into main

Reason why this change is needed

MR !1215 (merged) for enabling MASA external renderer tests fails in pipeline 183021 for rendering to Ambisonics with a USAN null-pointer error:

usan_log_test_masa[20ms-MASA1-FOA].18497:SUMMARY: UndefinedBehaviorSanitizer: nullptr-with-nonzero-offset /builds/rep/ivas-codec-pc/ivas-codec/lib_rend/ivas_dirac_rend.c:2144:56

Command:

/builds/rep/ivas-codec-pc/ivas-codec/IVAS_rend -i /builds/rep/ivas-codec-pc/ivas-codec/tests/renderer/data/spectral_test_8ch_48kHz.wav -if 7_1 -o /builds/rep/ivas-codec-pc/ivas-codec/tests/renderer/cut/7_1_to_BINAURAL_ROOM_REVERBNoneNone.wav -of BINAURAL_ROOM_REVERB -fs 48 -no_delay_cmp -q

Link to test pipeline: 183021

This seems to be related to #879 (closed) in internal renderer solved in MR !1186 (merged).

Description of the change

Add a null pointer guard in accessing the signal powers. Similar to the solution in !1186 (merged) for the internal renderer.

Affected operating points

  • External renderer when using MASA input.
  • Bitstreams and internal renderer outputs are expected to be BE.

Related to #897 (closed)

Edited by Jouni Paulus

Merge request reports