Skip to content

[non-BE] Fix issue 981 by setting parambin early part correction to unity also when on...

Tapani Pihlajakuja requested to merge 981-fix-parambin-default-early-part-correction-in-room-reverb into main

Reason why this change is needed

It was noticed as part of the work enabling BINAURAL_ROOM_REVERB mode for ParamBin in MR !1280 (merged) that there could be a minor difference in direct part levels. This is due to reuse of the parameter parametricEarlyPartEneCorrection from the default BRIR intended for BINAURAL_ROOM_IR mode. A simple fix is to set this parameters as one for all frequency bands in a suitable place.

Description of the change

The simple fix is done. On BINAURAL_ROOM_REVERB path, the internal structure in binaural renderer is set to unity.

Affected operating points

  • Encoder and bitstream are not changed, thus BE.
  • Decoder and renderer are changed.
  • This affects all modes that use ParamBin with output mode BINAURAL_ROOM_REVERB. This should be MASA, OMASA, SBA up to 80 kbps, McMASA, and ParamISM.
  • The effect should not be too significant but can be audible as a difference spectrum.

Related to #981 (closed)

Edited by Tapani Pihlajakuja

Merge request reports