Skip to content

[Non BE] Handle subframes shorter than filter length in TD renderer for JBM operation

norvellrequested to merge
1176-asan-stack-buffer-underflow-in-osba-with-binaural_room_rverb-output into main

Reason why this change is needed

  • The JBM requests frames that are 1.25 ms, which is shorter than the length of the filter of the TD renderer. The memory update operation assumed the subframe was longer than the filter, which lead to out-of-buffer access and output corruption.

Description of the change

  • The memory update is done using the local filter buffer, which has the memory of the previous frame prepended.

Affected operating points

  • Affects usage of the TD renderer where output frames shorter than 128 samples are requested. Observed for JBM operation of OSBA with reverb.

Related to #1176 (closed)

Merge request reports