[Non BE] Resolve "DFT Stereo residual PLC, time_offset counter wraps around for burst errors"
requested to merge 1208-dft-stereo-residual-plc-time_offset-counter-wraps-around-for-burst-errors into main
- Related issues: #1208 (closed)
- Requested reviewers: @fotopoulou
Reason why this change is needed
- For long burst errors (>204 frames) the counter
time_offs
in the DFT Stereo residual PLC overflows. At this point, the output is anyhow attenuated. - A bug in the memory handling for the good-frame was found, where the output_frame was used instead of L_FRAME8k. Fixing this removed the need of the output_frame from the function altogether, which triggered some more changes.
- The onset of the PLC frame still has a discontinuity, which is more or less the same with and without the fix. This is not addressed, and might need further study.
Description of the change
- Saturate increase of time_offs when it reaches MAX_16B.
Affected operating points
- 32 kbps stereo with frame errors. Since it is used in the CPE, the difference may spread further.
Related to #1208 (closed)