Skip to content

[Non-BE][Rend Non-BE][Split Non-BE]Add NONBE_1300_TDREND_LARGE_ITD to address potential out-of-buffer access for large ITDs

norvellrequested to merge
1300-decoder-adresssanitizer-global-buffer-overflow-in-sincresample-osba_ism3_hoa3_b128_wb_cbr into main

Reason why this change is needed

  • The TD renderer was exposed to 1.25 ms subframes. This was a bug that is now resolved. However, it can still happen that an out-of-buffer access happens if a modeled HRTF has large ITDs.

Description of the change

  • The ITD transition is assumed to complete within the subframe. A check is added to ensure the transition can be done. If it cannot, the target ITD is changed such that part of the transition is delayed.

Affected operating points

  • TD renderer with custom HRTFs, having large ITDs. There is currently a MAX_ITD ivas_cnst.h set to 50, and an ITD of 40 would already coincide with the frame length at WB.

Related to #1300 (closed)

Edited by norvell

Merge request reports