Skip to content

Draft: Resolve "RTPDUMP is not RTPDUMP"

Stefan Doehlarequested to merge
1438-rtpdump-is-not-rtpdump into main

Reason why this change is needed

  • When the encoder/decoder are in RTPDUMP/VoIP mode then no longer the rtpdump.h/rtpdump.c files are used which have been used by EVS. The alternative implementation in lib_util/ivas_rtp_file.c allows encoder/decoder round-trip but it is in fact not using the RTPDUMP format that is specified at https://www.cs.columbia.edu/~hgs/software/rtptools/ and which has been used previously in other 3GPP exercises. Using the real format would also be essential to check real-world packet captures. This has been noticed during spec writing and checking the respective code.

    When looking at this also three bugs in reading rtpdump and mime_io introduced by SMALL_CODE_IMPROVEMENTS have been identified that went unnoticed - likely because the files were not in use.

Description of the change

  • Using rtpdump.h / rtpdump.c in lib_util instead of direct file-reading/writing

Affected operating points

  • All RTPDUMP operation points. Those would be non-BE. The PCM outputs should though not change as this is purely systems-related.
    • Note that normally RTPDUMP files contain a timestamp when it was captured. This may need to be fixated.

Related to #1438

Merge request reports