Skip to content

Split Rendering codec frame size support in RTP ToC SR byte

Ripinder Singhrequested to merge
rtp_sr_framesize_support_in_toc_byte into main

To estimate the correct frame size of a SR frame in RTP payload, it is important to know the codec's frame size employed in addition to the bitrate. This can be propagated from SDP, this work extends to resolve this info from the ToC byte which makes it easier to parse an rtpdump even if the sdp negotiated codec frame size is not available.

This MR implements the suggested CR update to the ToC byte to signal codec frame size in ms.

Changes in ISAR post-renderer

  • Add a preview of the RTP stream to extract the codec, and framesize fields as reported in the RTP SR ToC byte
  • Override the user provided renderer frame-size to codec frame-size in rtp cases to prevent bitstream read errors due to unparsed padding in the end of ISAR bitstream.
  • Remove the external SR CodecFrameSize from RTP API SR CodecFrameSize read from RTP stream, hence no need to be set externally.
Edited by Ripinder Singh

Merge request reports