Skip to content

[Non-BE] Fixing the SBA MSAN issue properly, with non-BE Switch in the right place

Adam Mills requested to merge 698-Fix-SBA-MSAN-issue-properly into main

Basic Info

Reason why this change is needed

  • Originally there was an MSAN issue where uninitialised memory was being read. A first fix was to initialise the memory to zero, this fixed the MSAN issue however the actual fix should have been to limit the time slices being examined.

Description of the change

  • Reverts the initial fix and properly modifies the mono detector to look at the correct time slices.
  • Slightly more mono is now detected in some of the test cases, however this is acceptable.

Affected operating points

  • test_sba_plc_system[0-16-PLperc42mblen2-stvFOA-1-32000] fail on linux by 1 bit.
  • 21 SBA Selections tests are failing after this change.
Edited by Adam Mills

Merge request reports