[Non-BE] Resolve "SBA DTX with bitrate switching use of uninitialized value"
Basic Info
- Related issues: #723 (closed)
- Requested reviewers: @weckbecker
Reason why this change is needed
- MSAN issue when switching bitrates.
Description of the change
-
This MR fixes two sanitizer issues in SBA DTX mode with bitrate switching (observed with same CMD line).
-
Fix 1 includes mapping of DirAC's Energy_ratio_index in SID frames correctly (note that SID frames are coded with reduced number of bands but before rendering/upmixing these reduced number of bands must be mapped to active frame's band config) to avoid uninitialized memory access.
-
Fix 2 fixes the mapping of SPAR bands in frames where MD is coded in inactive mode but core coder is running in active mode. Given the overall status of the frame is active frame, mapping logic should look at current frame's bitrate and not last_active_frame's bitrate.
Affected operating points
- Non-BE for some SBA cases.
- Bitstream is BE as changes are only in the decoder, but audio output may differ.
Long Test Log
Edited by Adam Mills